Add pythonPackages.immutables, pythonPackages.contextvars #40189
Conversation
| sha256 = "1hba0vkqanwfnb5b3rs14bs7schsmczhan5nd93c1i6fzi17glap"; | ||
| }; | ||
|
|
||
| buildInputs = [ stdenv ]; |
| buildPythonPackage rec { | ||
| pname = "contextvars"; | ||
| version = "2.2"; | ||
| disabled = pythonOlder "3.6"; |
There was a problem hiding this comment.
This is a
backport of Python 3.7 contextvars module (see PEP 567) for Python 3.6
and should therefore be disabled for any version other than 3.6.
| buildPythonPackage rec { | ||
| pname = "immutables"; | ||
| version = "0.5"; | ||
| disabled = pythonOlder "3.6"; |
There was a problem hiding this comment.
This should be pythonOlder "3.5":
immutables requires Python 3.5+
|
|
||
| meta = { | ||
| description = "Capture the outcome of Python function calls."; | ||
| homepage = https://github.com/MagicStack/contextvars; |
There was a problem hiding this comment.
Wrong description and homepage
pkgs/top-level/python-packages.nix
Outdated
| @@ -533,6 +533,10 @@ in { | |||
|
|
|||
| asyncio = callPackage ../development/python-modules/asyncio {}; | |||
|
|
|||
| immutables = callPackage ../development/python-modules/immutables {}; | |||
|
|
|||
| contextvars = callPackage ../development/python-modules/contextvars {}; | |||
There was a problem hiding this comment.
The attributes in this file should be ordered alphabetically
| propagatedBuildInputs = [ immutables ]; | ||
|
|
||
| meta = { | ||
| description = "Capture the outcome of Python function calls."; |
| propagatedBuildInputs = [ immutables ]; | ||
|
|
||
| meta = { | ||
| description = "This package implements a backport of Python 3.7 contextvars module for Python 3.6."; |
There was a problem hiding this comment.
No period: https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes
And for the purpose of brevity, I'd leave out "This package implements"/
| }; | ||
|
|
||
| meta = { | ||
| description = "An immutable mapping type for Python."; |
There was a problem hiding this comment.
|
@GrahamcOfBorg build python3.pkgs.immutables python3.pkgs.contextvars |
|
Success on x86_64-linux (full log) Attempted: python3.pkgs.immutables, python3.pkgs.contextvars Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python3.pkgs.immutables, python3.pkgs.contextvars Partial log (click to expand)
|
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)