Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bat: 0.2.0 -> 0.3.0 #40206

Merged
merged 1 commit into from
May 9, 2018
Merged

bat: 0.2.0 -> 0.3.0 #40206

merged 1 commit into from
May 9, 2018
+6 −6

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented May 9, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jD91mZM2
jD91mZM2 reviewed May 9, 2018
View reviewed changes
pkgs/tools/misc/bat/default.nix Outdated
license = licenses.mit;
maintainers = [];
license = with licenses; [ asl20 /* or */ mit ];
maintainers = with maintainers; [ gywedir ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dywedir*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 9, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bat

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/examples'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i625s0pfvmn60hb5alwbvslfwv0pqacp-bat-0.3.0
shrinking /nix/store/i625s0pfvmn60hb5alwbvslfwv0pqacp-bat-0.3.0/bin/bat
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i625s0pfvmn60hb5alwbvslfwv0pqacp-bat-0.3.0/bin
patching script interpreter paths in /nix/store/i625s0pfvmn60hb5alwbvslfwv0pqacp-bat-0.3.0
checking for references to /build in /nix/store/i625s0pfvmn60hb5alwbvslfwv0pqacp-bat-0.3.0...
/nix/store/i625s0pfvmn60hb5alwbvslfwv0pqacp-bat-0.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bat

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8xzcypbngyx4n9jygns9w847khqda796-bat-0.3.0
shrinking /nix/store/8xzcypbngyx4n9jygns9w847khqda796-bat-0.3.0/bin/bat
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8xzcypbngyx4n9jygns9w847khqda796-bat-0.3.0/bin
patching script interpreter paths in /nix/store/8xzcypbngyx4n9jygns9w847khqda796-bat-0.3.0
checking for references to /build in /nix/store/8xzcypbngyx4n9jygns9w847khqda796-bat-0.3.0...
/nix/store/8xzcypbngyx4n9jygns9w847khqda796-bat-0.3.0

@xeji xeji merged commit cbe420d into NixOS:master May 9, 2018
@dywedir dywedir deleted the bat branch May 9, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jD91mZM2 jD91mZM2

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @GrahamcOfBorg @jD91mZM2 @xeji