Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librsvg: 2.42.3 → 2.42.4 #40197

Merged
merged 1 commit into from May 10, 2018
Merged

librsvg: 2.42.3 → 2.42.4 #40197

merged 1 commit into from May 10, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented May 9, 2018 •
edited

Motivation for this change

Changes: https://gitlab.gnome.org/GNOME/librsvg/blob/2.42.4/NEWS

I also enabled installed tests, which you can run using env XDG_DATA_DIRS=$(nix-build -A librsvg.installedTests)/share nix-shell -p gnome-desktop-testing --run 'gnome-desktop-testing-runner' but at the moment it fails because they refer to /build directory. (upstream bug)

Regular tests are still failing, opened an upstream issue: https://gitlab.gnome.org/GNOME/librsvg/issues/258

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: librsvg

Partial log (click to expand)

shrinking /nix/store/5fvvmnm6ysji3iv1aks17zklbq7ijnpb-librsvg-2.42.4-installedTests/libexec/installed-tests/RSVG/loading
shrinking /nix/store/5fvvmnm6ysji3iv1aks17zklbq7ijnpb-librsvg-2.42.4-installedTests/libexec/installed-tests/RSVG/rsvg-test
shrinking /nix/store/5fvvmnm6ysji3iv1aks17zklbq7ijnpb-librsvg-2.42.4-installedTests/libexec/installed-tests/RSVG/crash
shrinking /nix/store/5fvvmnm6ysji3iv1aks17zklbq7ijnpb-librsvg-2.42.4-installedTests/libexec/installed-tests/RSVG/render-crash
shrinking /nix/store/5fvvmnm6ysji3iv1aks17zklbq7ijnpb-librsvg-2.42.4-installedTests/libexec/installed-tests/RSVG/dimensions
strip is /nix/store/q2aqbrb18bhmisv5kcgbddikf63ywhqg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5fvvmnm6ysji3iv1aks17zklbq7ijnpb-librsvg-2.42.4-installedTests/libexec
patching script interpreter paths in /nix/store/5fvvmnm6ysji3iv1aks17zklbq7ijnpb-librsvg-2.42.4-installedTests
checking for references to /build in /nix/store/5fvvmnm6ysji3iv1aks17zklbq7ijnpb-librsvg-2.42.4-installedTests...
/nix/store/pk3l28yg5466f2q5h1m16g8khllbq0my-librsvg-2.42.4

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: librsvg

Partial log (click to expand)

cannot build derivation '/nix/store/2wv2lafxa1a8q41rw5nlk4fyjz16n76k-texlive-core-big.bin-2017.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/s08lfycaz4j2jxdqr2xlvcv3xvvdc8k3-graphviz-2.40.1.drv': 21 dependencies couldn't be built
cannot build derivation '/nix/store/dbrg8zicrv2ks74ay9f5vvkfn9l4rhl0-texlive-combined-2017.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/pj4nwyclmax2wdjy18n4i165drzj91di-dblatex-0.3.10.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/48lappjvvvlnjdv56pwp3mnc9a5kmppp-vala-0.38.4.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/1cgnpd5kbmk3s68164w47bcjl7w7y63l-gtk-doc-1.28.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/frwpbl4p8755m0qlhnxj7s80sjvq94fm-gdk-pixbuf-2.36.12.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/b853lbh8bdf74gbm1mnryzfqywk0cr79-libgsf-1.14.42.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/wdrbwwkrivjxx4f174avagw5wykwi8ir-librsvg-2.42.4.drv': 18 dependencies couldn't be built
error: build of '/nix/store/wdrbwwkrivjxx4f174avagw5wykwi8ir-librsvg-2.42.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: librsvg

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/q8l3415brp3bms7f1ljrzq7vxsxrrss7-vala-0.38.4/lib  /nix/store/q8l3415brp3bms7f1ljrzq7vxsxrrss7-vala-0.38.4/bin
patching script interpreter paths in /nix/store/q8l3415brp3bms7f1ljrzq7vxsxrrss7-vala-0.38.4
/nix/store/q8l3415brp3bms7f1ljrzq7vxsxrrss7-vala-0.38.4/bin/vala-gen-introspect-0.38: interpreter directive changed from "/bin/sh" to "/nix/store/6p33wkvaa9al68sc9vx18arwg9cnnmsk-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/q8l3415brp3bms7f1ljrzq7vxsxrrss7-vala-0.38.4...
shrinking RPATHs of ELF executables and libraries in /nix/store/h6x2pnfkh7xrkjlpcngcyzka9nr56d5m-vala-0.38.4-devdoc
strip is /nix/store/3j464112pjp8gym60b88glvl2kmsn0ph-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h6x2pnfkh7xrkjlpcngcyzka9nr56d5m-vala-0.38.4-devdoc
checking for references to /build in /nix/store/h6x2pnfkh7xrkjlpcngcyzka9nr56d5m-vala-0.38.4-devdoc...
cannot build derivation '/nix/store/rwvwxjw7l5birin5b1lw2kkdimrq4gjj-librsvg-2.42.4.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/rwvwxjw7l5birin5b1lw2kkdimrq4gjj-librsvg-2.42.4.drv' failed

@xeji xeji merged commit 99514b7 into NixOS:staging May 10, 2018
@jtojnar jtojnar mentioned this pull request May 10, 2018
Closed
@jtojnar jtojnar deleted the librsvg-2.42.4 branch July 15, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @GrahamcOfBorg @xeji