Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Changes: https://gitlab.gnome.org/GNOME/librsvg/blob/2.42.4/NEWS
I also enabled installed tests, which you can run using
env XDG_DATA_DIRS=$(nix-build -A librsvg.installedTests)/share nix-shell -p gnome-desktop-testing --run 'gnome-desktop-testing-runner'
but at the moment it fails because they refer to/build
directory. (upstream bug)Regular tests are still failing, opened an upstream issue: https://gitlab.gnome.org/GNOME/librsvg/issues/258
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)