Disable installing frameworks for qt #40187
Conversation
We prefer to have $out/include & $out/lib installed so that things like multiple outputs can work. There is no way to do this in Qt currently without also disabling the ‘framework’ install. Not sure if this will break anything but it will fix issues we run into on some projects like python2.7-pyside: Linux: https://hydra.nixos.org/build/73219181 macOS: https://hydra.nixos.org/build/73059550 Hopefully this gives us consistency between the two.
matthewbauer
requested review from
Ericson2314,
FRidh,
nbp,
orivej,
peti,
ttuegel and
zimbatm
as code owners
GrahamcOfBorg
added
6.topic: qt/kde
6.topic: GNOME
| @@ -37,9 +37,7 @@ let | |||
| srcs = import ./srcs.nix { inherit fetchurl; inherit mirror; }; | |||
|
|
|||
| patches = { | |||
| qtbase = [ ./qtbase.patch ] ++ | |||
| optionals stdenv.isDarwin [ ./qtbase-darwin.patch | |||
There was a problem hiding this comment.
No its listed below. It used to be optional but it’s safe to apply everywhere (this is going to staging anyway).
| @@ -16,6 +16,9 @@ let | |||
| optional (!debug) "-DQT_NO_DEBUG" | |||
| ++ lib.toList (args.NIX_CFLAGS_COMPILE or []); | |||
|
|
|||
| configureFlags = [ "-no-framework" ] | |||
| ++ (args.configureFlags or []); | |||
There was a problem hiding this comment.
@matthewbauer This broke audaciousQt5 (https://hydra.nixos.org/build/74997027) and is out of place here because it is used for all packages defined with libsForQt5.callPackage. Could you move -no-framework away?
There was a problem hiding this comment.
Where can we put this though? I think qmake flags is the right place maybe?
There was a problem hiding this comment.
It seems that -no-framework should only apply to Qt configure, and should not be passed to any qmake. Am I right?
There was a problem hiding this comment.
Yes that will work. My confusion is from thinking that all qt derivations use the configure script. Most will just use qmake & hopefully -no-framework is remembered.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually this fixed quite a few packages: https://hydra.nixos.org/eval/1460869#tabs-now-succeed
There was a problem hiding this comment.
Awesome! Do you know what's going on with the cancelled builds?
There was a problem hiding this comment.
@vcunat has cancelled them to free up resources for staging builds; there should be no manually cancelled builds once staging is merged.
Motivation for this change
Qt will not install things in the normal place on Darwin unless we add this flag. It just tells Qt to not install the framework and work in the normal "Unix" style where /lib & /include are installed to.