Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkitgtk: add missing libXdamage dependency #40195

Merged
merged 1 commit into from
May 9, 2018

Conversation

emmanuelrosa
Copy link
Contributor

Motivation for this change

webkitgtk-2.4.11 fails to build due to a missing dependency on libXdamage. This change is needed so that gnucash-2.6 builds, which in turn is needed to provide an upgrade path from gnucash-2.4 (previous default) to gnucash-3.1 (new default). See #39616

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Note: I successfully ran gnucash-2.6 with this change.

Sorry, something went wrong.

@matthewbauer matthewbauer merged commit fba7c3a into NixOS:master May 9, 2018
@emmanuelrosa emmanuelrosa deleted the webkitgtk-xdamage branch May 9, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants