Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dokuwiki/dokuwiki
base: eb1b5958c991
Choose a base ref
...
head repository: dokuwiki/dokuwiki
compare: 98a151bacda1
Choose a head ref
  • 5 commits
  • 16 files changed
  • 1 contributor

Commits on May 18, 2018

  1. sucess is green

    @splitbrain
    splitbrain committed May 18, 2018
    Copy the full SHA
    e98b5e4 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2018

  1. Also allow test files ending in Test.php 

    This makes it possible to give test files proper PSR-2 names where the
file is named after the class name.
    @splitbrain
    splitbrain committed May 20, 2018
    Copy the full SHA
    5d703e3 View commit details
    Browse the repository at this point in the history

  2. extract save checking into own method 

    Instead of having the out() method return empty strings, a new method
tells the writer if a setting should be saved or not. Only then the
out() method is called.
    @splitbrain
    splitbrain committed May 20, 2018
    Copy the full SHA
    f00299d View commit details
    Browse the repository at this point in the history

  3. proper defaults for initialize 

    There isn't really unset variables, but we do expect null to be passed
for some of them.

This also moves the update method further up as it's logically the next
step.
    @splitbrain
    splitbrain committed May 20, 2018
    Copy the full SHA
    af40dea View commit details
    Browse the repository at this point in the history

  4. Some first Setting class tests

    @splitbrain
    splitbrain committed May 20, 2018
    Copy the full SHA
    98a151b View commit details
    Browse the repository at this point in the history