Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0ad: 0.0.22 -> 0.0.23 #40807

Merged
merged 1 commit into from May 20, 2018
Merged

0ad: 0.0.22 -> 0.0.23 #40807

merged 1 commit into from May 20, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change
  1. General update
  2. Get rid of old SDL1 dependency which is no longer needed.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented May 20, 2018

@GrahamcOfBorg build 0ad

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: 0ad

Partial log (click to expand)

Cannot nix-instantiate `0ad' because:
�[31;1merror:�[0m attribute '0ad' in selection path '0ad' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: 0ad

Partial log (click to expand)

Cannot nix-instantiate `0ad' because:
�[31;1merror:�[0m attribute '0ad' in selection path '0ad' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: 0ad

Partial log (click to expand)

Cannot nix-instantiate `0ad' because:
error: attribute '0ad' in selection path '0ad' not found

@Mic92
Copy link
Member

Mic92 commented May 20, 2018

@GrahamcOfBorg build zeroad

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: zeroad

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1icncryfnsfb21dxwyvrk494d0j1si6m-0ad-data-0.0.23
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/1icncryfnsfb21dxwyvrk494d0j1si6m-0ad-data-0.0.23
checking for references to /build in /nix/store/1icncryfnsfb21dxwyvrk494d0j1si6m-0ad-data-0.0.23...
cannot build derivation '/nix/store/y6aa5xnzi6pw3axfhn2802z46vgj2a2b-zeroad-0.0.23.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/y6aa5xnzi6pw3axfhn2802z46vgj2a2b-zeroad-0.0.23.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: zeroad

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zeroad

Partial log (click to expand)

shrinking /nix/store/4r3nr10ayvi6686krwb4m8l3c0ni09y7-0ad-0.0.23/bin/ActorEditor
shrinking /nix/store/4r3nr10ayvi6686krwb4m8l3c0ni09y7-0ad-0.0.23/lib/0ad/libAtlasUI.so
shrinking /nix/store/4r3nr10ayvi6686krwb4m8l3c0ni09y7-0ad-0.0.23/lib/0ad/libCollada.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4r3nr10ayvi6686krwb4m8l3c0ni09y7-0ad-0.0.23/lib  /nix/store/4r3nr10ayvi6686krwb4m8l3c0ni09y7-0ad-0.0.23/bin
patching script interpreter paths in /nix/store/4r3nr10ayvi6686krwb4m8l3c0ni09y7-0ad-0.0.23
checking for references to /build in /nix/store/4r3nr10ayvi6686krwb4m8l3c0ni09y7-0ad-0.0.23...
building '/nix/store/3j9j5x93pivmz1a9s7sxc5pvmzsbp33d-zeroad-0.0.23.drv'...
created 9 symlinks in user environment
/nix/store/6i6d3rnic6jlkc6w1r9anr4gdrw458rm-zeroad-0.0.23

@peterhoeg
Copy link
Member Author

peterhoeg commented May 20, 2018 •
edited

@Mic92 do you know why grahamofborg didn't automatically build this?

@7c6f434c
Copy link
Member

Because it builds the attribute mentioned in the PR title, and 0ad means 0 ad for the Nix parser which is not an expression Nix can build.

@peterhoeg
Copy link
Member Author

Ah, got it. Thanks @7c6f434c

@xeji xeji merged commit d7679fb into NixOS:master May 20, 2018
@peterhoeg peterhoeg deleted the u/0ad branch May 21, 2018 00:15
@peterhoeg peterhoeg restored the u/0ad branch May 21, 2018 02:11
globin pushed a commit to mayflower/nixpkgs that referenced this pull request May 24, 2018
@peterhoeg @globin
0ad: 0.0.22 -> 0.0.23 (NixOS#40807)
72252a8 
(cherry picked from commit d7679fb)
@peterhoeg peterhoeg deleted the u/0ad branch April 4, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterhoeg @Mic92 @GrahamcOfBorg @7c6f434c @xeji