Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix xf86-video-amdgpu #40791

Merged
merged 2 commits into from May 20, 2018
Merged

fix xf86-video-amdgpu #40791

merged 2 commits into from May 20, 2018

Conversation

corngood
Copy link
Contributor

Motivation for this change

The amdgpu driver has been failing to build for a while due to missing gbm, which is provided by mesa_noglu. I was unable to (easily) bisect where it was broken (probably in the great libGL migration?) due to xorgserver being broken for big chunks of recent history.

I also fixed the problems I found with the xorg expression generator, so it can be run again without generating diffs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

- update versions in .list files to match
- move cf-files postInstall to overrides.nix
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very nice IMO.

@vcunat vcunat merged commit 456d0e2 into NixOS:master May 20, 2018
vcunat added a commit that referenced this pull request May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants