Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-vendor: fix build #40808

Merged
merged 2 commits into from May 20, 2018
Merged

cargo-vendor: fix build #40808

merged 2 commits into from May 20, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 20, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented May 20, 2018

@GrahamcOfBorg build cargo-vendor

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cargo-vendor

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/alb7j9m3cpmfkr6dp45s24l5bcipq43x-rust_cargo-vendor-0.1.13
shrinking /nix/store/alb7j9m3cpmfkr6dp45s24l5bcipq43x-rust_cargo-vendor-0.1.13/bin/cargo-vendor
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/alb7j9m3cpmfkr6dp45s24l5bcipq43x-rust_cargo-vendor-0.1.13/lib  /nix/store/alb7j9m3cpmfkr6dp45s24l5bcipq43x-rust_cargo-vendor-0.1.13/bin
patching script interpreter paths in /nix/store/alb7j9m3cpmfkr6dp45s24l5bcipq43x-rust_cargo-vendor-0.1.13
checking for references to /build in /nix/store/alb7j9m3cpmfkr6dp45s24l5bcipq43x-rust_cargo-vendor-0.1.13...
/nix/store/alb7j9m3cpmfkr6dp45s24l5bcipq43x-rust_cargo-vendor-0.1.13

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cargo-vendor

Partial log (click to expand)

warning: redundant linker flag specified for library `ssl`

warning: redundant linker flag specified for library `z`

installing
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/74f9c2j0h9j65fsa1qgf0z3nv0i87dp2-rust_cargo-vendor-0.1.13/lib  /nix/store/74f9c2j0h9j65fsa1qgf0z3nv0i87dp2-rust_cargo-vendor-0.1.13/bin
patching script interpreter paths in /nix/store/74f9c2j0h9j65fsa1qgf0z3nv0i87dp2-rust_cargo-vendor-0.1.13
/nix/store/74f9c2j0h9j65fsa1qgf0z3nv0i87dp2-rust_cargo-vendor-0.1.13

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cargo-vendor

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5ws1fjbz186vvi5rqif5c6q73m95nls4-rust_cargo-vendor-0.1.13
shrinking /nix/store/5ws1fjbz186vvi5rqif5c6q73m95nls4-rust_cargo-vendor-0.1.13/bin/cargo-vendor
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5ws1fjbz186vvi5rqif5c6q73m95nls4-rust_cargo-vendor-0.1.13/lib  /nix/store/5ws1fjbz186vvi5rqif5c6q73m95nls4-rust_cargo-vendor-0.1.13/bin
patching script interpreter paths in /nix/store/5ws1fjbz186vvi5rqif5c6q73m95nls4-rust_cargo-vendor-0.1.13
checking for references to /build in /nix/store/5ws1fjbz186vvi5rqif5c6q73m95nls4-rust_cargo-vendor-0.1.13...
/nix/store/5ws1fjbz186vvi5rqif5c6q73m95nls4-rust_cargo-vendor-0.1.13

@Mic92 Mic92 merged commit 9d3693b into NixOS:master May 20, 2018
@Mic92 Mic92 deleted the rust-curl-sys branch May 20, 2018 11:04
@infinisil
Copy link
Member

Unfortunately a new nixos-unstable landed 11 hours ago without this fix, as a result at least the build of alacritty and ripgrep is broken there.

@Mic92
Copy link
Member Author

Mic92 commented May 21, 2018

At least nixos-unstable-small includes this patch again.

@Gerschtli Gerschtli mentioned this pull request Jun 4, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @infinisil @P-E-Meunier