lfe: 1.2.1 -> 1.3 #40785
lfe: 1.2.1 -> 1.3 #40785
Conversation
|
/ping @ankhers |
|
Why do we need to keep the old version? |
|
We keep old versions of other BEAM languages because many people still use them. In the case of LFE, there aren't very many users, especially on Nix, so it's more for uniformity across BEAM packages than anything else. |
| lfe_1_2 = lib.callLFE ../interpreters/lfe/1.2.nix { inherit erlang buildRebar3 buildHex; }; | ||
| lfe_1_3 = lib.callLFE ../interpreters/lfe/1.3.nix { inherit erlang buildRebar3 buildHex; }; |
There was a problem hiding this comment.
Do we need both lfe_1_2 and 1.3? The rule of thumb is, that we usually do this for projects where multiple maintained major versions exists. This seems not the case here.
|
@yurrriq I suppose the older erlang versions are still maintained upstream and only major versions are kept. I am not familiar with LFE, will older versions still receive updates? Were there breaking changes in the last minor release? lfe/lfe@v1.2.1...v1.3 |
|
I really don't use LFE anymore, so I'm not motivated to get this working. |
Motivation for this change
Hack together an
lfe_1_3derivation and make it the defaultlfe.Notably, the following now works.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)