Slimserver: Fix media scanning & transcoding #40778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix up the commit message for e0e1adb to conform to contributing.md? (nixos/slimserver: ...) For the backport, you should cherry pick your commits onto a branch based on release-18.03 and make a separate PR targeting that branch. :) |
8 tasks
|
Thanks for the review :-) Fixed commit messages and opened a separate PR for the backport. |
srhb
added a commit
that referenced
this pull request
May 23, 2018
nixos/slimserver: Fix media scanning & transcoding (backport #40778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes media scanning slimserver: indexing doesn't work #40589 by disabling video/image scanning
(slimserver is mainly used as Audio Server for Logitech Squeezeboxes)
Fixes media transcoding
It would be nice to backport this to 18.03, but I have no idea how to do that?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)