Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x2goclient: qt4 -> qt5 #40811

Merged
merged 1 commit into from May 20, 2018
Merged

x2goclient: qt4 -> qt5 #40811

merged 1 commit into from May 20, 2018

Conversation

averelld
Copy link
Contributor

Motivation for this change

Gets rid of the qt4 dependency. See #40793 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 20, 2018

@GrahamcOfBorg build x2goclient

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: x2goclient

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: x2goclient

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l4cqqdhsx5dv71kf92v2hni8h4hzz90y-x2goclient-4.1.1.1
shrinking /nix/store/l4cqqdhsx5dv71kf92v2hni8h4hzz90y-x2goclient-4.1.1.1/bin/.x2goclient-wrapped
gzipping man pages under /nix/store/l4cqqdhsx5dv71kf92v2hni8h4hzz90y-x2goclient-4.1.1.1/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l4cqqdhsx5dv71kf92v2hni8h4hzz90y-x2goclient-4.1.1.1/bin
patching script interpreter paths in /nix/store/l4cqqdhsx5dv71kf92v2hni8h4hzz90y-x2goclient-4.1.1.1
checking for references to /build in /nix/store/l4cqqdhsx5dv71kf92v2hni8h4hzz90y-x2goclient-4.1.1.1...
postPatchMkspecs
/nix/store/l4cqqdhsx5dv71kf92v2hni8h4hzz90y-x2goclient-4.1.1.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: x2goclient

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sf271blyd1wgjyakszi3rpq0z7lxjqsj-x2goclient-4.1.1.1
shrinking /nix/store/sf271blyd1wgjyakszi3rpq0z7lxjqsj-x2goclient-4.1.1.1/bin/.x2goclient-wrapped
gzipping man pages under /nix/store/sf271blyd1wgjyakszi3rpq0z7lxjqsj-x2goclient-4.1.1.1/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sf271blyd1wgjyakszi3rpq0z7lxjqsj-x2goclient-4.1.1.1/bin
patching script interpreter paths in /nix/store/sf271blyd1wgjyakszi3rpq0z7lxjqsj-x2goclient-4.1.1.1
checking for references to /build in /nix/store/sf271blyd1wgjyakszi3rpq0z7lxjqsj-x2goclient-4.1.1.1...
postPatchMkspecs
/nix/store/sf271blyd1wgjyakszi3rpq0z7lxjqsj-x2goclient-4.1.1.1

@xeji
Copy link
Contributor

xeji commented May 20, 2018

Thank you! Looks nicer on qt5 😄
/cc #33248

@xeji xeji merged commit e92d68e into NixOS:master May 20, 2018
@averelld averelld deleted the x2goclient-update branch June 23, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @xeji @GrahamcOfBorg