Expand tilde to home directory in NIX_PATH #2170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that Nix path expressions can start with a tilde, allow the same for NIX_PATH entries.
|
@grahamc just hit this for paths in nix.conf too, might be nice there. |
|
@dezgeg Can Nix path expressions actually start with a tilde, or is that just shell expansion? |
|
Yes they do: Line 377 in 1ad1923 |
shlevy
approved these changes
May 21, 2018
|
This might not always be clear who's home should be used depending on evaluation. I hit this sometimes when I lazily point src to local repo with tilde and it works until I run with sudo :). FWIW "~user" syntax is not supported. |
|
I'm concerned about the variability of where it resolves, and the ~user/ not being supported. I wonder if a better approach would be to error (?) on '~/foo` files which don't exist? |
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Nix path expressions can start with a tilde, allow the same for NIX_PATH entries.
This is needed for fixing NixOS/nixpkgs#40165 (or well, my suggestion in NixOS/nixpkgs#40165 (comment) depends on that) so this should be picked to the 2.0.x branch as well.