purple-lurch: init at 0.6.7 #40795
Merged
purple-lurch: init at 0.6.7 #40795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To add plugin, add |
disassembler
suggested changes
May 20, 2018
| { stdenv, fetchFromGitHub, pidgin, minixml, libxml2, sqlite, libgcrypt, cmake }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "purple-lurch-0.6.7"; |
There was a problem hiding this comment.
split version into it's separate variable
| src = fetchFromGitHub { | ||
| owner = "gkdr"; | ||
| repo = "lurch"; | ||
| rev = "3156e14c2dcf9968438aceb7fda8f82eae6f552d"; |
There was a problem hiding this comment.
Since is a release on upstream github repo, just do "v${version}" instead of specifying rev manually.
added 2 commits
May 20, 2018 21:32
Adds XEP-0384: OMEMO Encryption for libpurple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This change adds the pidgin/libpurple plugin lurch, which provides an implementation for XEP-0384: OMEMO Encryption. As long as the XMPP server of both parties supports OMEMO, this plugin allows for encrypted messaging. See https://github.com/gkdr/lurch
Things done
build-use-sandboxinnix.confon non-NixOS)[ ] macOSTechnically should build on macOS, but I have no way of confirming.[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)[ ] Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"pidgin