Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pciutils: build with dns query support #40796

Merged
merged 1 commit into from May 20, 2018
Merged

pciutils: build with dns query support #40796

merged 1 commit into from May 20, 2018

Conversation

benley
Copy link
Member

@benley benley commented May 19, 2018

This enables lspci -q to look up unknown PCI IDs via DNS queries
without needing the update-pciids script that the derivation doesn't
include.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@benley
pciutils: build with dns query support
e385ca7 
This enables `lspci -q` to look up unknown PCI IDs via DNS queries
without needing the `update-pciids` script that the derivation doesn't
include.
@Mic92
Copy link
Member

Mic92 commented May 19, 2018

@GrahamcOfBorg build pciutils

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pciutils

Partial log (click to expand)

shrinking /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/lib/libpci.so.3.5.6
shrinking /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/sbin/setpci
shrinking /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/sbin/lspci
gzipping man pages under /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/lib  /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/sbin
patching script interpreter paths in /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6
checking for references to /build in /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6...
moving /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/sbin/* to /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/bin
/nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pciutils

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pciutils

Partial log (click to expand)

shrinking /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6/sbin/setpci
shrinking /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6/sbin/lspci
shrinking /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6/lib/libpci.so.3.5.6
gzipping man pages under /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6/lib  /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6/sbin
patching script interpreter paths in /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6
checking for references to /build in /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6...
moving /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6/sbin/* to /nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6/bin
/nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pciutils

Partial log (click to expand)

shrinking /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/lib/libpci.so.3.5.6
shrinking /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/sbin/lspci
shrinking /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/sbin/setpci
gzipping man pages under /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/lib  /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/sbin
patching script interpreter paths in /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6
checking for references to /build in /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6...
moving /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/sbin/* to /nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6/bin
/nix/store/dfq79afyk3hn8pxl1vs656j3dxjs5xa3-pciutils-3.5.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pciutils

Partial log (click to expand)

/nix/store/sflihhg8agynm8kpwj506g1697qrqn9k-pciutils-3.5.6

@Mic92
Copy link
Member

Mic92 commented May 19, 2018

This triggers 15k rebuilds. I think it should go to staging first.

@vcunat vcunat changed the base branch from master to staging May 20, 2018 11:24
@vcunat vcunat merged commit e385ca7 into NixOS:staging May 20, 2018
vcunat added a commit that referenced this pull request May 20, 2018
@vcunat
Merge #40796: pciutils: build with dns query support
b33e666
@vcunat
Copy link
Member

vcunat commented May 20, 2018

It's a pity that staging has become such a black hole this month.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pciutils

Partial log (click to expand)

these paths will be fetched (0.36 MiB download, 1.60 MiB unpacked):
  /nix/store/g2099phymq4bzayk9qy462h64bp1s4gr-kmod-25
  /nix/store/wrlkxs0m55psi2jdqhb9jggsr2riw5gd-pciutils-3.5.6
copying path '/nix/store/g2099phymq4bzayk9qy462h64bp1s4gr-kmod-25' from 'https://cache.nixos.org'...
copying path '/nix/store/wrlkxs0m55psi2jdqhb9jggsr2riw5gd-pciutils-3.5.6' from 'https://cache.nixos.org'...
/nix/store/wrlkxs0m55psi2jdqhb9jggsr2riw5gd-pciutils-3.5.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pciutils

Partial log (click to expand)

shrinking /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6/sbin/setpci
shrinking /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6/sbin/lspci
shrinking /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6/lib/libpci.so.3.5.6
gzipping man pages under /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6/share/man/
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6/lib  /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6/sbin
patching script interpreter paths in /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6
checking for references to /build in /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6...
moving /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6/sbin/* to /nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6/bin
/nix/store/60fs46wk0a5qpp2w9y76zpjga43q9iyk-pciutils-3.5.6

@benley
Copy link
Member Author

benley commented May 21, 2018

Holy cow, it did not occur to me that this would result in a mass rebuild. Thanks for pointing that out, @vcunat.

@benley benley deleted the benley/lspci-dns branch May 21, 2018 02:45
@vcunat
Copy link
Member

vcunat commented May 21, 2018

That wasn't me but Mic92 who (I presume) just looked at what the Borg automatically reported...

@benley
Copy link
Member Author

benley commented May 21, 2018

ahem yes that. Thanks in general, all ye who are are better at paying attention to words than I am.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benley @Mic92 @GrahamcOfBorg @vcunat