Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: update pullImage syntax #40813

Closed
wants to merge 1 commit into from
Closed

kubernetes: update pullImage syntax #40813

wants to merge 1 commit into from

Conversation

kliu128
Copy link

@kliu128 kliu128 commented May 20, 2018

Based on changes in #38371.

Motivation for this change

Kubernetes no longer evaluated on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@kliu128
Copy link
Author

kliu128 commented May 20, 2018

Whoops, looks like a duplicate of #40665. Closing.

@kliu128 kliu128 closed this May 20, 2018
@kliu128 kliu128 deleted the kubernetes-fix-pull-image branch May 20, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kliu128 @GrahamcOfBorg