Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn: use nodejs 8.x #40815

Closed
wants to merge 1 commit into from
Closed

yarn: use nodejs 8.x #40815

wants to merge 1 commit into from

Conversation

kliu128
Copy link

@kliu128 kliu128 commented May 20, 2018

Motivation for this change

Some npm packages no longer install correctly when using the Node.js 6.x that is currently used, such as openpgp:

[nix-shell:~]$ yarn
yarn install v1.6.0
[1/4] Resolving packages...
[2/4] Fetching packages...
error openpgp@3.0.7: The engine "node" is incompatible with this module. Expected version ">= 8.0.0".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Node.js 6.x is also a maintenance LTS now, whereas 8.x is an Active LTS until April 2019.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented May 20, 2018

Maybe it is time to point nodejs attribute to 8.x globally.

@lukateras
Copy link
Member

lukateras commented May 22, 2018 •
edited

I agree with @jtojnar, we should point nodejs to nodejs-8_x globally. AFAIK, there are no major compatibility issues between those versions.

@flokli
Copy link
Contributor

flokli commented May 22, 2018

so let's do that instead and see what breaks? :-)

@lukateras
Copy link
Member

Pretty much.

@lukateras lukateras mentioned this pull request May 22, 2018
Merged
@lukateras
Copy link
Member

Superseded by #40938.

@lukateras lukateras closed this May 22, 2018
@kliu128 kliu128 deleted the yarn-nodejs-8 branch May 22, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kliu128 @jtojnar @lukateras @flokli @GrahamcOfBorg