Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "iasl: 20180313 -> 20180508 (#40613)" #40781

Closed
wants to merge 1 commit into from
Closed

Revert "iasl: 20180313 -> 20180508 (#40613)" #40781

wants to merge 1 commit into from

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented May 19, 2018 •
edited

Broke xen and virtualbox.
This reverts commit 5e49920.

Motivation for this change

See #40613 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji @Synthetica9
Revert "iasl: 2018031 -> 20180508 (NixOS#40613)"
92ef2ef 
Broke xen and virtualbox.
This reverts commit 5e49920.
@xeji
Copy link
Contributor

xeji commented May 19, 2018

@Synthetica9 to have a clean git history, the revert commit should reference the original commit on the gcc8 branch (not the one on master).
Reverted in a581c10 , closing this.

@xeji xeji closed this May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @xeji @GrahamcOfBorg