nixos/xsslock: wait until pgrep xlock succeeds
#40810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please refer to the conversation in the original PR (NixOS#40619) for further reference: NixOS#40619 (comment) It takes some time after the standby to trigger the locker which might break the test on Hydra.
|
/cc @xeji hopefully this fixes the broken test %) |
|
the i686 build passes now on Hydra. The x86 build (https://hydra.nixos.org/build/74478142) remains broken. If I understand the log correctly it times out while waiting for /dev/vda. Therefore we can be fairly sure that this is a simple Hydra issue. I’d wait and observe how the tests behave during the next builds and then we can decide whether or not to consider this fixed :) |
|
The x86 failure is unrelated. I've seen these several times before. Looks like a sporadic issue on the hydra builder - the VM doesn't find its primary disk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Please refer to the conversation in the original PR (#40619) for further
reference: #40619 (comment)
It takes some time after the standby to trigger the locker which might
break the test on Hydra.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)