Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.git-dit: Fix darwin build #40802

Merged
merged 1 commit into from May 20, 2018
Merged

gitAndTools.git-dit: Fix darwin build #40802

merged 1 commit into from May 20, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes the git-dit build on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label May 20, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitAndTools.git-dit

Partial log (click to expand)

these paths will be fetched (1.14 MiB download, 3.93 MiB unpacked):
  /nix/store/yhbrn9mv257px13a03arcnnvpsidrkgd-git-dit-0.4.0
copying path '/nix/store/yhbrn9mv257px13a03arcnnvpsidrkgd-git-dit-0.4.0' from 'https://cache.nixos.org'...
/nix/store/yhbrn9mv257px13a03arcnnvpsidrkgd-git-dit-0.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitAndTools.git-dit

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0
shrinking /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0/bin/git-dit
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0/bin
patching script interpreter paths in /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0
checking for references to /build in /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0...
/nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0

@Mic92
Copy link
Member

Mic92 commented May 20, 2018

@GrahamcOfBorg build gitAndTools.git-dit

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitAndTools.git-dit

Partial log (click to expand)

these paths will be fetched (1.14 MiB download, 3.93 MiB unpacked):
  /nix/store/yhbrn9mv257px13a03arcnnvpsidrkgd-git-dit-0.4.0
copying path '/nix/store/yhbrn9mv257px13a03arcnnvpsidrkgd-git-dit-0.4.0' from 'https://cache.nixos.org'...
/nix/store/yhbrn9mv257px13a03arcnnvpsidrkgd-git-dit-0.4.0

@Mic92
Copy link
Member

Mic92 commented May 20, 2018

I think you could upgrade your ofborg account to trusted users so macOS is build as well.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitAndTools.git-dit

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/incremental'
cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/examples'
cp: -r not specified; omitting directory 'target/release/deps'
cp: -r not specified; omitting directory 'target/release/build'
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/phg1jxv0fcm1zsbhjj1726rg1kqil06r-git-dit-0.4.0/bin
patching script interpreter paths in /nix/store/phg1jxv0fcm1zsbhjj1726rg1kqil06r-git-dit-0.4.0
/nix/store/phg1jxv0fcm1zsbhjj1726rg1kqil06r-git-dit-0.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitAndTools.git-dit

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0
shrinking /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0/bin/git-dit
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0/bin
patching script interpreter paths in /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0
checking for references to /build in /nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0...
/nix/store/k5zvjpahqj1a738vrh5g3fmv5vf58shi-git-dit-0.4.0

@Mic92 Mic92 merged commit 8ac7c7f into NixOS:master May 20, 2018
@knedlsepp
Copy link
Member Author

@Mic92 Is there some kind of policy on becoming a trusted ofborg user? Currently I don't have any special privileges in the NixOS realm and I don't know how I would prove my trustworthiness.

@Mic92
Copy link
Member

Mic92 commented May 22, 2018 •
edited

@knedlsepp there is no policy. This is decided based on past contributions a user did. You can quote this thread when asking for it. Since you seems to work on macOS, having access to ofborg's macOS builder makes sense.

@knedlsepp knedlsepp mentioned this pull request Jun 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @GrahamcOfBorg @Mic92