Nixos/boot: fixing yubikey dynamic linking #40805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please test this with #29441? I confirmed this and that branches to merge.
Rebase of this onto that: https://github.com/oxij/nixpkgs/tree/pull/40805-yubikey-linking, just in case.
|
|
Hi ! Is this still an issue ? If so - what would we need to do to get this one merged ? Thanks ! |
|
Nope, not an issue anymore, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
After changes in the
yubikey-personalizationpackage, a dynamically-linked library could not be found. This PR fixes this.The bug is relatively serious: it is luckily caught by tests at updates (causing all NixOS updates in the last n months to fail silently for an unknown n), but any mistake there could potentially make encrypted partitions undecipherable.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)