Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.blank-canvas: 0.6.3 -> 0.6.2 #39903

Merged
merged 1 commit into from May 4, 2018
Merged

haskellPackages.blank-canvas: 0.6.3 -> 0.6.2 #39903

merged 1 commit into from May 4, 2018

Conversation

endgame
Copy link
Contributor

@endgame endgame commented May 3, 2018

Motivation for this change

blank-canvas-0.6.3 depends on base-compat-batteries-0.10, which
depends on base-compat-0.10. This conflicts with the rest of the LTS
set, which uses base-compat-0.9. No base-compat-batteries-0.9 exists.

blank-canvas-0.6.2 only depends on base-compat >= 0.8 && < 0.10.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@endgame
haskellPackages.blank-canvas: 0.6.3 -> 0.6.2
4680fe6 
blank-canvas-0.6.3 depends on base-compat-batteries-0.10, which
depends on base-compat-0.10. This conflicts with the rest of the LTS
set, which uses base-compat-0.9. No base-compat-batteries-0.9 exists.

blank-canvas-0.6.2 only depends on base-compat >= 0.8 && < 0.10.
@endgame endgame requested a review from peti as a code owner May 3, 2018 02:19
@peti
Copy link
Member

peti commented May 3, 2018

Wouldn't it make more sense to add base-compat-batteries == 0.10.* so that we can build the latest version of blank-canvas instead?

@endgame
Copy link
Contributor Author

endgame commented May 3, 2018

Quite possible. I held back base-compat-batteries because base-compat-0.9.3 is still what's being used in stackage nightlies.

I made a test stack project on LTS-11.7, added base-compat-0.10.1 to extra-deps and added every revdep stackage knew about that was in the LTS snapshot and tried to build:

In the dependencies for aeson-1.2.4.0:
    base-compat-0.10.1 from stack configuration does not match >=0.9.1 && <0.10 (latest matching version is 0.9.3)
needed due to z-0.1.0.0 -> aeson-1.2.4.0

In the dependencies for haxr-3000.11.2:
    base-compat-0.10.1 from stack configuration does not match >=0.8 && <0.10 (latest matching version is 0.9.3)
needed due to z-0.1.0.0 -> haxr-3000.11.2

In the dependencies for rest-core-0.39:
    base-compat-0.10.1 from stack configuration does not match >=0.8 && <0.10 (latest matching version is 0.9.3)
needed due to z-0.1.0.0 -> rest-core-0.39

In the dependencies for rest-snap-0.3.0.0:
    base-compat-0.10.1 from stack configuration does not match >=0.8 && <0.10 (latest matching version is 0.9.3)
needed due to z-0.1.0.0 -> rest-snap-0.3.0.0

In the dependencies for rest-types-1.14.1.2:
    base-compat-0.10.1 from stack configuration does not match >=0.8 && <0.10 (latest matching version is 0.9.3)
needed due to z-0.1.0.0 -> rest-types-1.14.1.2

In the dependencies for tdigest-0.1:
    base-compat-0.10.1 from stack configuration does not match >=0.9.1 && <0.10 (latest matching version is 0.9.3)
needed due to z-0.1.0.0 -> tdigest-0.1

In the dependencies for wl-pprint-text-1.1.1.0:
    base-compat-0.10.1 from stack configuration does not match >=0.9 && <0.10 (latest matching version is 0.9.3)
needed due to z-0.1.0.0 -> wl-pprint-text-1.1.1.0

So it seems like a decent number of packages haven't fixed their bounds for base-compat-0.10. Which way do you want me to take this? Holding back blank-canvas or pushing a bunch of other stuff forward?

@peti
Copy link
Member

peti commented May 4, 2018

I see! Well, I think you should choose whatever solution works best for you. Maybe it's too soon to upgrade to base-compat-batteries == 0.10.x.

@peti peti merged commit f2b5813 into NixOS:master May 4, 2018
@endgame endgame deleted the hold-blank-canvas branch May 4, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@endgame @peti @GrahamcOfBorg