Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: fix aarch64 by disabling two doc tests #38999

Closed
wants to merge 1 commit into from
Closed

rustc: fix aarch64 by disabling two doc tests #38999

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 16, 2018

The patch is based on hydra's output and untested: https://hydra.nixos.org/build/72883318/nixlog/1

Those did not compile for some reason:

failures:

---- num/mod.rs - num::u32::next_power_of_two (line 2213) stdout ----
error: Error during translation/LLVM phase.

thread 'rustc' panicked at 'couldn't compile the test', librustdoc/test.rs:298:13

---- num/mod.rs - num::u8::is_ascii_punctuation (line 2623) stdout ----
error: Error during translation/LLVM phase.

thread 'rustc' panicked at 'couldn't compile the test', librustdoc/test.rs:298:13

failures:
num/mod.rs - num::u32::next_power_of_two (line 2213)
num/mod.rs - num::u8::is_ascii_punctuation (line 2623)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
rustc: fix aarch64 by disabling two doc tests
7b4d700 
those did not compile for some reason:

failures:

---- num/mod.rs - num::u32::next_power_of_two (line 2213) stdout ----
        error: Error during translation/LLVM phase.

thread 'rustc' panicked at 'couldn't compile the test', librustdoc/test.rs:298:13

---- num/mod.rs - num::u8::is_ascii_punctuation (line 2623) stdout ----
        error: Error during translation/LLVM phase.

thread 'rustc' panicked at 'couldn't compile the test', librustdoc/test.rs:298:13

failures:
    num/mod.rs - num::u32::next_power_of_two (line 2213)
    num/mod.rs - num::u8::is_ascii_punctuation (line 2623)
@Mic92 Mic92 requested a review from LnL7 as a code owner April 16, 2018 11:22
@Mic92
Copy link
Member Author

Mic92 commented Apr 16, 2018

cc @bkchr

@Mic92
Copy link
Member Author

Mic92 commented Apr 16, 2018

replaced by #39000

@Mic92 Mic92 closed this Apr 16, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rustc

Partial log (click to expand)

/nix/store/y2xgc99ybahiml2camiycm592gsi8mc7-rustc-1.25.0

@dezgeg
Copy link
Contributor

dezgeg commented Apr 16, 2018

It's not those two specific tests, just intermittent failures. You see the same LLVM error in https://nix-cache.s3.amazonaws.com/log/whsyh46wr0zfkw420xcc8ffgahszsd80-rustc-1.24.0.drv as well.

@Mic92 Mic92 deleted the rustc branch April 16, 2018 12:26
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: rustc

Partial log (click to expand)

   Compiling syntax_pos v0.0.0 (file:///build/rustc-1.25.0-src/src/libsyntax_pos)
   Compiling rls-span v0.4.0
   Compiling rls-data v0.15.0
   Compiling rustc_errors v0.0.0 (file:///build/rustc-1.25.0-src/src/librustc_errors)
   Compiling backtrace v0.3.5
   Compiling rustc_const_math v0.0.0 (file:///build/rustc-1.25.0-src/src/librustc_const_math)
   Compiling proc_macro v0.0.0 (file:///build/rustc-1.25.0-src/src/libproc_macro)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.25.0-src/src/libsyntax_ext)
building of '/nix/store/zk2h9j7sl1z8665wx8qvgfdcv7xkgaga-rustc-1.25.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/zk2h9j7sl1z8665wx8qvgfdcv7xkgaga-rustc-1.25.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Merge failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @dezgeg