Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New psych failures with 3.0.3 + updated tests. #5142

Closed
headius opened this issue Apr 16, 2018 · 6 comments
Closed

New psych failures with 3.0.3 + updated tests. #5142

headius opened this issue Apr 16, 2018 · 6 comments
Milestone
Non-Release

Comments

@headius
Copy link
Member

headius commented Apr 16, 2018

For #5098 I am about to release Psych 3.0.3 and use it in JRuby 9.1.17. However updating the tests (required because some older deprecated tests no longer load) exposes some failures. These may be regressions in the JRuby part of Psych, but they are more likely one of the following:

  • fixes that were made to the C code in Psych but not the Java code
  • minor behavioral differences between libyaml and SnakeYAML
  • regressions in SnakeYAML

I will be tagging them for now.
@headius
Copy link
Member Author

headius commented Apr 16, 2018

@enebo How concerned do you think we should be putting 9.1.17 out with these failures? I'm not sure how new they are; we have updated Psych a few times without updating tests, and had not seen these failures up until now.

@enebo
Copy link
Member

enebo commented Apr 16, 2018

@headius I guess it depends on how ominous the failures look. Do they look like someone would be depending on behavior that changed?

@headius
Copy link
Member Author

headius commented Apr 16, 2018

@enebo They didn't look too ominous to me, but I'm not sure what some of them are testing. I'll push the excludes shortly.

@headius
Copy link
Member Author

headius commented Apr 16, 2018

Ok...so it looks like there's spec failures too. This probably needs to be addressed before we release with the new Psych/SnakeYAML.

I will push a pre gem and a branch to get a complete listing of failures.

@headius headius added this to the JRuby 9.2.0.0 milestone Apr 16, 2018
@headius headius mentioned this issue Apr 16, 2018
Closed
headius added a commit to ruby/psych that referenced this issue Apr 16, 2018
@headius
Bump version to 3.0.3.pre1 for testing for jruby/jruby#5142.

Verified

This commit was signed with the committer’s verified signature.
wyattjoh Wyatt Johnson
GPG key ID: C56A4C5DA36B212A
Verified
Learn about vigilant mode
97af871
headius added a commit that referenced this issue Apr 16, 2018
@headius
Update Psych and its tests to 3.0.3.pre1. See #5142.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
39b94f2 
There are several failures, either regressions in JRuby's psych
code or in SnakeYAML, or new failures from issues only fixed in
the psych C code.
@headius headius mentioned this issue Apr 16, 2018
Closed
@headius
Copy link
Member Author

headius commented Apr 17, 2018

I removed my patch for excludes since we now have a complete accounting of failures in this build: https://travis-ci.org/jruby/jruby/jobs/367441040

headius added a commit that referenced this issue Apr 27, 2018
@headius
Tag remaining Psych failures, since we have other issues (#5142)

Verified

This commit was signed with the committer’s verified signature.
wyattjoh Wyatt Johnson
GPG key ID: C56A4C5DA36B212A
Verified
Learn about vigilant mode
f848082
@headius headius mentioned this issue May 15, 2018
Closed
@enebo enebo modified the milestones: JRuby 9.2.0.0, JRuby 9.2.1.0 May 24, 2018
kares added a commit to kares/jruby that referenced this issue Oct 23, 2018
@kares
Revert "Tag remaining Psych failures, since we have other issues (jru…
0b113fd 
…by#5142)"

This reverts commit f848082.
@headius headius removed this from the JRuby 9.2.1.0 milestone Oct 26, 2018
@headius
Copy link
Member Author

headius commented Jul 23, 2020

I've done a re-update of Psych tests and excludes and I don't think there's a need to keep this issue open. The remaining issues are mostly minor differences in SnakeYAML behavior or other small features we'll get to.

@headius headius closed this as completed Jul 23, 2020
@headius headius added this to the Non-Release milestone Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

No branches or pull requests
2 participants
@headius @enebo