Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browserpass: fix gnupg dependency issue #39009

Merged
merged 1 commit into from Apr 16, 2018
Merged

browserpass: fix gnupg dependency issue #39009

merged 1 commit into from Apr 16, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 16, 2018

Motivation for this change

Browserpass depends on gnupg being available in the system, and if the user doesn't have gnupg as a system util (which isn't reasonable to assume) it just won't work.

Pass itself is patched for which gnupg it uses and pass abstracts alot of the gnupg usage, so even if the user use gnupg it's absolutely not required for them to ever interact with the gnupg binary itself.

This should resolve #33748.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: browserpass

Partial log (click to expand)

strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9dpic1xi7zr2wvv0r3yh0d38d68rar0f-browserpass-2.0.18-bin/lib  /nix/store/9dpic1xi7zr2wvv0r3yh0d38d68rar0f-browserpass-2.0.18-bin/bin
patching script interpreter paths in /nix/store/9dpic1xi7zr2wvv0r3yh0d38d68rar0f-browserpass-2.0.18-bin
checking for references to /build in /nix/store/9dpic1xi7zr2wvv0r3yh0d38d68rar0f-browserpass-2.0.18-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/n3wa8m8ym0m01frnr7cil76ksx3xf0j9-browserpass-2.0.18
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/n3wa8m8ym0m01frnr7cil76ksx3xf0j9-browserpass-2.0.18
/nix/store/n3wa8m8ym0m01frnr7cil76ksx3xf0j9-browserpass-2.0.18/share/go/src/github.com/dannyvankooten/browserpass/install.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/n3wa8m8ym0m01frnr7cil76ksx3xf0j9-browserpass-2.0.18...
/nix/store/9dpic1xi7zr2wvv0r3yh0d38d68rar0f-browserpass-2.0.18-bin

@etu
Copy link
Contributor Author

etu commented Apr 16, 2018

cc @rvolosatovs

@Mic92 Mic92 merged commit 6bad8dd into NixOS:master Apr 16, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 16, 2018

18.03: c0c5571

@etu etu deleted the browserpass-fix branch April 16, 2018 21:21
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: browserpass

Partial log (click to expand)

copying path '/nix/store/j6c4znwbi218qzhx7y9jwhg1h6kbmlak-gdk-pixbuf-2.36.7' from 'https://cache.nixos.org'...
copying path '/nix/store/9cspif3di102ih29c59q6j7bgbg9lhw9-harfbuzz-1.7.6' from 'https://cache.nixos.org'...
copying path '/nix/store/lzw1r3a3jhgj9k455p34cmdpb4mn7fgh-libsecret-0.18.5' from 'https://cache.nixos.org'...
copying path '/nix/store/c3djs9j4lfjcy5f1j7n6x5yk1096b44z-cups-2.2.6-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/vapz18fx9pni0lw770vff3r7zmra2ggc-pango-1.40.14' from 'https://cache.nixos.org'...
copying path '/nix/store/rhmcfxy204491jxy0l1436jrjv2xxn1l-gtk+-2.24.32' from 'https://cache.nixos.org'...
copying path '/nix/store/4ycfch3afmm3src1z25grpg70i7rridy-pinentry-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/xgfak1drdai1vmgmm917wff3m7wd7q7m-gnupg-2.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/kzmgpyzx77rn776fdqznca0kd1x0g08n-browserpass-2.0.18-bin' from 'https://cache.nixos.org'...
/nix/store/kzmgpyzx77rn776fdqznca0kd1x0g08n-browserpass-2.0.18-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

browserpass does not taltk to firefox 57
4 participants
@etu @GrahamcOfBorg @Mic92 @rvolosatovs