Do not capture or propagate to main any Unrescuable exceptions.

Unrescuable exceptions in JRuby are used for internal operations, usually involving the termination of a thread or of the running program. They should not be captured as the terminal state of a Ruby thread, nor should they be propagated across threads. This was causing CI to terminate (with a success return code) on 9.1 and master.
jruby · Apr 16, 2018 · 7464f3a · 7464f3a
1 parent 9549f5d
commit 7464f3a
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/core/src/main/java/org/jruby/RubyThread.java b/core/src/main/java/org/jruby/RubyThread.java
@@ -62,6 +62,7 @@
 import org.jruby.anno.JRubyMethod;
 import org.jruby.exceptions.RaiseException;
 import org.jruby.exceptions.ThreadKill;
+import org.jruby.exceptions.Unrescuable;
 import org.jruby.internal.runtime.NativeThread;
 import org.jruby.internal.runtime.RubyRunnable;
 import org.jruby.internal.runtime.ThreadLike;
@@ -1638,6 +1639,11 @@ public void exceptionRaised(RaiseException exception) {
      * @param throwable
      */
     public void exceptionRaised(Throwable throwable) {
+        // if unrescuable (internal exceptions) just re-raise and let it be handled by thread handler
+        if (throwable instanceof Unrescuable) {
+            Helpers.throwException(throwable);
+        }
+
         Ruby runtime = getRuntime();
 
         assert isCurrent();