Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 29edb473f2fd
Choose a base ref
...
head repository: jruby/jruby
compare: 7e8c8489f42d
Choose a head ref
  • 4 commits
  • 86 files changed
  • 1 contributor

Commits on Apr 14, 2018

  1. Finish calls to symbol. Only weird bit here was zsuper and a couple o… 

    …f other

calls had implicit names which needed to be symbols but we had no way to make
them.  Passing in IRScope was the current solution.  Not end of the world, but
also not totally desirable.
    @enebo
    enebo committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    430f2b4 View commit details
    Browse the repository at this point in the history

  2. AST finalization: 

      - Remove getByteName
  - Make getName be getId (maybe to still leave us)
  - Make getSymbolName be getName
    @enebo
    enebo committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    0d30f3a View commit details
    Browse the repository at this point in the history

  3. No more getId in AST. 

    global variables now use RubySymbol.
    @enebo
    enebo committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    5532950 View commit details
    Browse the repository at this point in the history

  4. Restore method storage to jlString. Now known as 'id' Strings. This also 

    did away with the short-lived StringSupport methods.
    @enebo
    enebo committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    7e8c848 View commit details
    Browse the repository at this point in the history