Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dokuwiki/dokuwiki
base: 7dfce4513e19^
Choose a base ref
...
head repository: dokuwiki/dokuwiki
compare: a2c4af177103
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Apr 15, 2018

  1. Fix buttons with invalid empty name attributes 

    The search buttons from the search form on the top of the page
as well as the search page both produce invalid HTML
due to the name attribute being empty.
As the name is required for each of the PHP functions
producing the buttons and is passed as an empty string,
this makes sure that parameters with empty strings get skipped.
    @selfthinker
    selfthinker committed Apr 15, 2018
    Copy the full SHA
    7dfce45 View commit details
    Browse the repository at this point in the history

  2. Fix links with invalid empty target attributs 

    The advanced search options list links with an invalid empty target
attribute. This fixes that by skipping empty parameters.
    @selfthinker
    selfthinker committed Apr 15, 2018
    Copy the full SHA
    2163e81 View commit details
    Browse the repository at this point in the history

  3. Fix invalid HTML in search results 

    Recent changes to the search results page added various divs
to the pre-existing description list, which is invalid.
This fixes that by a) removing a couple of unnecessary elements
and b) interpret the 'last modified' line as another 'dd'.
    @selfthinker
    selfthinker committed Apr 15, 2018
    Copy the full SHA
    a2c4af1 View commit details
    Browse the repository at this point in the history