Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pure: 0.66 -> 0.68 #38927

Merged
merged 1 commit into from Apr 20, 2018
Merged

pure: 0.66 -> 0.68 #38927

merged 1 commit into from Apr 20, 2018

Conversation

asppsa
Copy link
Contributor

@asppsa asppsa commented Apr 14, 2018

Motivation for this change

Update Pure to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.


src = fetchurl {
url="https://bitbucket.org/purelang/${project}/downloads/${name}.${extension}";
sha256="42df6832476e8bee3a7ca179671284c1edd7bc82b71062fa0de62fd2117ee676";
url="https://github.com/agraef/pure-lang/releases/download/${name}/${name}.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rewrite this to use "fetchFromGitHub"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it's possible, but I'm not sure it is desirable.

The agraef/pure-lang repo is a "mega repo" containing Pure plus a bunch of Pure modules. The maintainer packages up parts of the repo and uploads them using github's releases functionality. If we used fetchFromGitHub, we would end up downloading a lot more than necessary just to build Pure.

Also, the release tarballs have had some autoconf, bison, etc. stuff run on them, so they have configure scripts, etc. ready to go. I would need to update the build script to run this stuff instead.

If you think it's still worthwhile, let me know and I'll make the changes.

Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok makes sense! Thanks

@matthewbauer matthewbauer merged commit 9a94dd5 into NixOS:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants