Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quakespasm, vkquake: enable userdirs support #38950

Merged
merged 1 commit into from Apr 20, 2018
Merged

quakespasm, vkquake: enable userdirs support #38950

merged 1 commit into from Apr 20, 2018

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

QuakeSpasm and vkQuake support loading game content from the ~/.quakespasm and ~/.vkquake directories, respectively. Enable the build flag to support this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: quakespasm, vkquake

Partial log (click to expand)

install /build/source/Quake/vkquake /nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3/bin/vkquake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3
shrinking /nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3/bin/vkquake
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3/bin 
patching script interpreter paths in /nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3
checking for references to /build in /nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3...
/nix/store/gar5rq7vfz6vzwh73wic7aj08cpd429r-quakespasm-0.92.1
/nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: quakespasm, vkquake

Partial log (click to expand)

install /build/source/Quake/vkquake /nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3/bin/vkquake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3
shrinking /nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3/bin/vkquake
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3/bin
patching script interpreter paths in /nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3
checking for references to /build in /nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3...
/nix/store/flaznbdkx4mqcbcksvkpwsshvshyl82z-quakespasm-0.92.1
/nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3

@Mic92
Copy link
Member

Mic92 commented Apr 14, 2018

@GrahamcOfBorg build quakespasm, vkquake

@Mic92
Copy link
Member

Mic92 commented Apr 14, 2018

@GrahamcOfBorg build quakespasm vkquake

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: quakespasm, vkquake

Partial log (click to expand)

/nix/store/gar5rq7vfz6vzwh73wic7aj08cpd429r-quakespasm-0.92.1
/nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vkquake

The following builds were skipped because they don't evaluate on x86_64-linux: quakespasm,

Partial log (click to expand)

Cannot nix-instantiate `quakespasm,' because:
error: attribute ‘quakespasm,’ in selection path ‘quakespasm,’ not found

/nix/store/q9i5c3i0a6bgbrz4ak5fbwyxl36j7pkh-vkquake-0.97.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vkquake

The following builds were skipped because they don't evaluate on aarch64-linux: quakespasm,

Partial log (click to expand)

Cannot nix-instantiate `quakespasm,' because:
�[31;1merror:�[0m attribute 'quakespasm,' in selection path 'quakespasm,' not found

/nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: quakespasm,, vkquake

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: quakespasm, vkquake

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: quakespasm, vkquake

Partial log (click to expand)

/nix/store/flaznbdkx4mqcbcksvkpwsshvshyl82z-quakespasm-0.92.1
/nix/store/rk1ldrjrlbq272lq1d6q0lxj4zxmrzq5-vkquake-0.97.3

@matthewbauer matthewbauer merged commit 0fe77f4 into NixOS:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tadfisher @GrahamcOfBorg @Mic92 @matthewbauer