Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] thunderbird: pass less non-standard flags #38943

Closed
wants to merge 1 commit into from
Closed

[WIP] thunderbird: pass less non-standard flags #38943

wants to merge 1 commit into from

Conversation

lukateras
Copy link
Member

Prerequisite to #36449. Not tested yet.

@jerith666
Copy link
Contributor

This would not build for me. I've pushed two new commits on top of it that get it building and basically working:

https://github.com/jerith666/nixpkgs/tree/thunderbird-config-flags
c56165f Merge remote-tracking branch 'channels/nixos-unstable' into thunderbird-config-flags
c68c301 thunderbird: add libpulseaudio build input, disable tests

Only issue I've noticed is that pushing the "play" button in the preferences dialog to test the new-mail sound doesn't work. But I'm not sure it did before those changes either.

@jerith666
Copy link
Contributor

Oh, also: the test failure looks like this:

    make[3]: Entering directory '/build/objdir/comm/mail/test/mozmill'
    rm -rf ../../../../_tests/mozmill/../mozmill-virtualenv && \
    mkdir ../../../../_tests/mozmill/../mozmill-virtualenv && \
    unset MACOSX_DEPLOYMENT_TARGET && \
    /build/objdir/_virtualenv/bin/python ../../../../_tests/mozmill/resources/installmozmill.py ../../../../_tests/mozmill/../mozmill-virtualenv
    Using real prefix '/nix/store/9qjc0d5557h3dkpsvfq98b2k96lnb6pw-python-2.7.15'
    New python executable in /build/objdir/_tests/mozmill-virtualenv/bin/python
    Installing setuptools, pip, wheel...done.
    The directory '/homeless-shelter/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
    The directory '/homeless-shelter/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
    Processing /build/thunderbird-60.0/testing/mozbase/manifestparser
    Processing /build/thunderbird-60.0/testing/mozbase/mozfile
    Processing /build/thunderbird-60.0/testing/mozbase/mozinfo
    Processing /build/thunderbird-60.0/testing/mozbase/mozlog
    Processing /build/thunderbird-60.0/testing/mozbase/mozprofile
    Processing /build/thunderbird-60.0/testing/mozbase/mozcrash
    Processing /build/thunderbird-60.0/testing/mozbase/moznetwork
    Processing /build/thunderbird-60.0/testing/mozbase/mozprocess
    Processing /build/thunderbird-60.0/testing/mozbase/mozdevice
    Processing /build/thunderbird-60.0/testing/mozbase/mozrunner
    Processing /build/thunderbird-60.0/python/mozterm
    Processing ./jsbridge
    Processing ./mozmill
    Collecting six>=1.10.0 (from manifestparser==1.2)
      Retrying (Retry(total=4, connect=None, read=None, redirect=None)) after connection broken by 'NewConnectionError('<pip._vendor.requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff14a0950>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
      Retrying (Retry(total=3, connect=None, read=None, redirect=None)) after connection broken by 'NewConnectionError('<pip._vendor.requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff14a0ad0>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
      Retrying (Retry(total=2, connect=None, read=None, redirect=None)) after connection broken by 'NewConnectionError('<pip._vendor.requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff14a0c50>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
      Retrying (Retry(total=1, connect=None, read=None, redirect=None)) after connection broken by 'NewConnectionError('<pip._vendor.requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff14a0dd0>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
      Retrying (Retry(total=0, connect=None, read=None, redirect=None)) after connection broken by 'NewConnectionError('<pip._vendor.requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff14a0f50>: Failed to establish a new connection: [Errno -2] Name or service not known',)': /simple/six/
      Could not find a version that satisfies the requirement six>=1.10.0 (from manifestparser==1.2) (from versions: )
    No matching distribution found for six>=1.10.0 (from manifestparser==1.2)
    Python: 2.7.15 (default, Apr 29 2018, 23:18:59)
    [GCC 7.3.0]
    Failure to install packages
    make[3]: *** [Makefile:28: mozmill-virtualenv] Error 1
    make[3]: Leaving directory '/build/objdir/comm/mail/test/mozmill'

@jerith666
Copy link
Contributor

jerith666 commented Oct 28, 2018 •
edited

I've updated my fork of this with a merge that resolves the conflicts: jerith666@9ee0173

@lukateras
Copy link
Member Author

Going to pull that; thanks!

@lukateras lukateras self-assigned this Oct 28, 2018
@lukateras lukateras mentioned this pull request Feb 1, 2019
Closed
10 tasks
@lukateras
Copy link
Member Author

Closing in favor of #55026.

@lukateras lukateras closed this Feb 1, 2019
@lheckemann lheckemann deleted the yegortimoshenko-patch-2 branch July 13, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukateras lukateras

Labels
2.status: work-in-progress 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @jerith666 @matthewbauer @GrahamcOfBorg