Make post list shortcode independent of the reSt directive #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you forgot a file. |
|
Or 2 |
Kwpolska
approved these changes
Apr 15, 2018
| return output, template_deps | ||
|
|
||
| # Request file name from shortcode (Issue #2412) | ||
| Plugin.handler.nikola_shortcode_pass_filename = True |
There was a problem hiding this comment.
No newline at the end of file? What editor is this, notepad.exe?
| # OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE | ||
| # SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| """Post list directive for reStructuredText.""" |
| import uuid | ||
|
|
||
| import natsort | ||
| from docutils import nodes |
There was a problem hiding this comment.
Are these docutils imports necessary, and if yes, how can we get rid of them?
|
@Kwpolska I forgot to run falke8 on it, all those should be fixed now. |
Kwpolska
reviewed
Apr 15, 2018
|
|
||
| name = "post_list" | ||
|
|
||
| def handler(self, start=None, stop=None, reverse=False, tags=None, require_all_tags=False, categories=None, |
There was a problem hiding this comment.
@ralsina, perhaps move the long docstring from rest/post_list.py here?
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the actual code into a shortcode plugin, made the reSt directive use the handler.