Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback for new section editing. fixes #2311 #2312

Merged
merged 1 commit into from Apr 15, 2018
Merged

fallback for new section editing. fixes #2311 #2312

merged 1 commit into from Apr 15, 2018

Conversation

splitbrain
Copy link
Collaborator

The displayed message now shows the target that was passed, which should
help identifying the troubling plugin.

Instead of failing, we fix the data ourselves - this code will be
removed in the future.

@splitbrain
fallback for new section editing. fixes #2311
ac025fd 
The displayed message now shows the target that was passed, which should
help identifying the troubling plugin.

Instead of failing, we fix the data ourselves - this code will be
removed in the future.
@splitbrain splitbrain added this to the 🐱 Greebo milestone Apr 14, 2018
lpaulsen93
lpaulsen93 approved these changes Apr 14, 2018
View reviewed changes
Copy link
Collaborator

@lpaulsen93 lpaulsen93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I did not know the function func_get_args(); so I would have never come-up with this simple workaround myself.

michitux
michitux approved these changes Apr 15, 2018
View reviewed changes
Copy link
Collaborator

@michitux michitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can confirm that this fixes the include plugin. I am wondering if the message should maybe only be shown to admins but then again it won't be shown when ACLs are disabled so I think this is good.

@splitbrain splitbrain merged commit 8a00500 into master Apr 15, 2018
@splitbrain splitbrain deleted the seceditfallback branch April 15, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michitux michitux michitux approved these changes

@lpaulsen93 lpaulsen93 lpaulsen93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
🐱 Greebo
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@splitbrain @michitux @lpaulsen93