Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extundelete: fix build with e2fsprogs 1.44 #38954

Merged
merged 1 commit into from Apr 15, 2018
Merged

extundelete: fix build with e2fsprogs 1.44 #38954

merged 1 commit into from Apr 15, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Apr 14, 2018

Motivation for this change

Didn't build with e2fsprogs 1.44 because one of the inode fields was renamed and repurposed.

Please backport to 18.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji xeji mentioned this pull request Apr 14, 2018
Closed
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: extundelete

Partial log (click to expand)

Making install in src
  /nix/store/jy9knxp7nmw80jkf932axrs1b4p9k4hi-coreutils-8.29/bin/install -c extundelete '/nix/store/jayndzmal4blf9j53q2yh0621cwwwkky-extundelete-0.2.4/bin'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jayndzmal4blf9j53q2yh0621cwwwkky-extundelete-0.2.4
shrinking /nix/store/jayndzmal4blf9j53q2yh0621cwwwkky-extundelete-0.2.4/bin/extundelete
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jayndzmal4blf9j53q2yh0621cwwwkky-extundelete-0.2.4/bin 
patching script interpreter paths in /nix/store/jayndzmal4blf9j53q2yh0621cwwwkky-extundelete-0.2.4
checking for references to /build in /nix/store/jayndzmal4blf9j53q2yh0621cwwwkky-extundelete-0.2.4...
/nix/store/jayndzmal4blf9j53q2yh0621cwwwkky-extundelete-0.2.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: extundelete

Partial log (click to expand)

Making install in src
  /nix/store/0svz5all13h1lxkfbx5y9vvy6r4cy422-coreutils-8.29/bin/install -c extundelete '/nix/store/2ndznqrvr1crlhz16pc14p8nigab1fq8-extundelete-0.2.4/bin'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2ndznqrvr1crlhz16pc14p8nigab1fq8-extundelete-0.2.4
shrinking /nix/store/2ndznqrvr1crlhz16pc14p8nigab1fq8-extundelete-0.2.4/bin/extundelete
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2ndznqrvr1crlhz16pc14p8nigab1fq8-extundelete-0.2.4/bin
patching script interpreter paths in /nix/store/2ndznqrvr1crlhz16pc14p8nigab1fq8-extundelete-0.2.4
checking for references to /build in /nix/store/2ndznqrvr1crlhz16pc14p8nigab1fq8-extundelete-0.2.4...
/nix/store/2ndznqrvr1crlhz16pc14p8nigab1fq8-extundelete-0.2.4

@Mic92 Mic92 merged commit c79f3d8 into NixOS:master Apr 15, 2018
@xeji
Copy link
Contributor Author

xeji commented Apr 15, 2018

@Mic92 please backport to 18.03. Thank you.

@Mic92
Copy link
Member

Mic92 commented Apr 15, 2018

[detached HEAD a228c69] extundelete: fix build with e2fsprogs 1.44
Author: xeji xeji@cat3.de
Date: Sun Apr 15 01:23:07 2018 +0200
1 file changed, 8 insertions(+)

@xeji xeji deleted the p/extundelete branch April 15, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @Mic92