Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kalarm: init #38953

Merged
merged 1 commit into from Apr 15, 2018
Merged

kalarm: init #38953

merged 1 commit into from Apr 15, 2018

Conversation

lrittel
Copy link
Contributor

@lrittel lrittel commented Apr 14, 2018

Motivation for this change

The KAlarm program is not packaged yet although it is a part of the kdepim applications.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lrittel lrittel requested a review from ttuegel as a code owner April 14, 2018 23:36
@lrittel
Copy link
Contributor Author

lrittel commented Apr 14, 2018

I've set myself as the maintainer, but I think it would be more appropiate if the kdepim maintainer would take the maintainerships as KAlarm is a part of the pim suite.
Shall I add another commit changing the maintainership?
I am not too familiar with nix or KDE...


mkDerivation {
name = "kalarm";
meta = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with lib; and lose the lib references below.

@peterhoeg
Copy link
Member

To answer your question @rittelle, the more hands we can get on this, the better so please stay as maintainer for this package.

@lrittel lrittel deleted the kalarm branch April 24, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants