Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing RSS_PATH behavior. #3036

Merged
merged 2 commits into from Apr 15, 2018
Merged

Fixing RSS_PATH behavior. #3036

merged 2 commits into from Apr 15, 2018

Conversation

felixfontein
Copy link
Contributor

Fixes #3024 so that RSS_PATH behaves as advertised.

@Kwpolska
Copy link
Member

Please:

  • add a changelog entry
  • show the new behavior (what is generated if RSS_PATH = 'foo', RSS_PATH = 'bar/'?)

@felixfontein
Copy link
Contributor Author

RSS_PATH == 'foo' should result in output/en/foo/rss.xml, and RSS_PATH == 'bar/' in output/en/bar//rss.xml. So far I've only tested it with RSS_PATH == '' (the default value), which results in no behavior change (as expected).

@Kwpolska Kwpolska added this to the v7 maintenance milestone Apr 15, 2018
@Kwpolska
Copy link
Member

Works fine. I’ll handle the v7 backport (which is a reasonable idea).

@Kwpolska Kwpolska merged commit 2d5dae3 into master Apr 15, 2018
@felixfontein
Copy link
Contributor Author

Cool! Thanks also for backporting!

@felixfontein felixfontein deleted the fix-3024 branch April 15, 2018 12:35
@Kwpolska Kwpolska mentioned this pull request Apr 15, 2018
Closed
@felixfontein felixfontein mentioned this pull request Apr 15, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7 maintenance
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @Kwpolska