nixos/restic: init #38948
nixos/restic: init #38948
Conversation
| }; | ||
| repo = mkOption { | ||
| type = types.str; | ||
| default = "sftp:backup@prism.r:/backups/${config.name}"; |
There was a problem hiding this comment.
Not all nixos users are connect to retiolum yet. Also the machine would run out of storage.
| }; | ||
| initialize = mkOption { | ||
| type = types.bool; | ||
| default = false; |
There was a problem hiding this comment.
Is this option idempotent? Can the backup run multiple times when initialize = true; without breaking?
| }; | ||
| passwordFile = mkOption { | ||
| type = types.str; | ||
| default = toString <secrets/restic-password>; |
There was a problem hiding this comment.
we have no convention on <secrets> in nix path yet.
There was a problem hiding this comment.
maybe we should document the "stockholm way" somewhere ;)
Lassulus
force-pushed
the
restic-service
branch
2 times, most recently
from
f90b6c6
to
9404713
Compare
| #! ${pkgs.bash}/bin/bash | ||
| ${resticCmd} snapshots || ${resticCmd} init | ||
| ''); | ||
| ExecStart = pkgs.writeDash "rustic-${plan.name}" ( |
| ''); | ||
| ExecStart = pkgs.writeDash "rustic-${plan.name}" ( | ||
| "#! ${pkgs.bash}/bin/bash\n" + | ||
| concatMapStringsSep "\n" (dir: "${resticCmd} backup ${dir}") plan.dirs |
There was a problem hiding this comment.
nitpick (readability):
''
#! ${pkgs.bash}/bin/bash
${concatMapStringsSep "\n" (dir: "${resticCmd} backup ${dir}") plan.dirs}
''
Lassulus
force-pushed
the
restic-service
branch
from
9404713
to
7767fea
Compare
|
tested with: {...}: {
services.restic.backups.mybackup = {
directories = ["/tmp/foo"];
repository = "/tmp/backup";
passwordFile = "/etc/nixos/secrets/restic-password";
initialize = true;
};
} |
|
cc @fd0 |
| ''; | ||
| example = "sftp:backup@192.168.1.100:/backups/${name}"; | ||
| }; | ||
| directories = mkOption { |
There was a problem hiding this comment.
Can't you backup single files? I think a name like paths would be more appropriate.
| restartIfChanged = false; | ||
| serviceConfig = { | ||
| Type = "oneshot"; | ||
| ExecStart = map (dir: "${resticCmd} backup ${dir}") backup.directories; |
There was a problem hiding this comment.
Isn't restic backup some/file other/file allowed?
| type = types.listOf types.str; | ||
| default = []; | ||
| description = '' | ||
| Extra arguments to append to the restic command. |
There was a problem hiding this comment.
Since this is "appended" (not really) to all restic commands (init and backup), I think it's impossible to add backup-only options like --exclude-caches. That should however be possible.
As it was done for the borg service, I suggest adding extraInitArgs and extraBackupArgs options.
| systemd.services = | ||
| mapAttrs' (name: backup: | ||
| let | ||
| extraArguments = concatMapStringsSep " " (arg: "-o ${arg}") backup.extraArguments; |
There was a problem hiding this comment.
Since extraArguments is mapped to -o I think this should be mentioned in the description and the option renamed to extraOptions.
There was a problem hiding this comment.
Can be each key only specified once?
There was a problem hiding this comment.
Don't know about that but when reading extraArguments I think of something like restic --extra-arg.
|
Hu? I'm late to the party, is there anything in particular you'd like me to comment on @Mic92? |
|
@fd0 this was more meant as a general notification. Sometimes upstream developer have valuable input. |
|
Cool, thanks for letting me know! NixOS is on my list of things to try :) |
I'm currently using this to backup my machines. feedback is appreciated, it mostly just satisfies my use-cases.