Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path handler support for fragments #3032

Merged
merged 1 commit into from Apr 15, 2018
Merged

Add path handler support for fragments #3032

merged 1 commit into from Apr 15, 2018

Conversation

gwax
Copy link
Contributor

@gwax gwax commented Apr 15, 2018

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

Add support for fragments to path handlers: ex. link://slug/my-post#some_heading

@gwax gwax requested a review from Kwpolska April 15, 2018 08:14
Kwpolska
Kwpolska approved these changes Apr 15, 2018
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/path_handlers.rst
You can also add query strings (``?key=value``) for extra arguments, or pass keyword arguments to ``_link`` in templates (support and behavior depends on path handlers themselves)
Nikola supports special links with the syntax ``link://kind/name``. In
templates you can also use ``_link(kind, name)``. You can add
fragments (``#anchor``) and query strings (``?key=value``) for extra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated, I’ll update the generation script myself (and do a slight rephrasing, and add a warning about editing this file).

@Kwpolska
Copy link
Member

I’l also add a CHANGES.txt mention.

@Kwpolska Kwpolska merged commit c962f86 into master Apr 15, 2018
@Kwpolska Kwpolska deleted the path_handler_fragments branch April 15, 2018 09:49
Kwpolska added a commit that referenced this pull request Apr 15, 2018
@Kwpolska
Document #3032
d792c08 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gwax @Kwpolska