pysensors: init at 2017-07-13 #38957

guibou · 2018-04-15T08:55:51Z

Motivation for this change

Pysensors is a python package to read hardware sensors.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-04-15T10:54:44Z

pkgs/development/python-modules/pysensors/default.nix

+    sha256 = "1xvbxnkz55fk5fpr514263c7s7s9r8hgrw4ybfaj5a0mligmmrfm";
+  };
+
+  propagatedBuildInputs = [ lm_sensors ];


Since this isn't a python library, it belongs into buildInputs.

dotlambda · 2018-04-15T10:54:49Z

pkgs/development/python-modules/pysensors/default.nix

+  meta = with stdenv.lib; {
+    maintainers = with maintainers; [ guibou ];
+    description = "Easy hardware health monitoring in Python for Linux systems";
+    homepage = "http://pysensors.readthedocs.org";


dotlambda · 2018-04-15T10:55:02Z

pkgs/development/python-modules/pysensors/default.nix

+    maintainers = with maintainers; [ guibou ];
+    description = "Easy hardware health monitoring in Python for Linux systems";
+    homepage = "http://pysensors.readthedocs.org";
+    licence = licencses.bsd2;


dotlambda · 2018-04-15T10:56:03Z

pkgs/development/python-modules/pysensors/default.nix

+  version = "2018-04-15";
+  pname = "pysensors";
+
+  src = fetchFromGitHub {


Please add a comment that https://pypi.org/project/PySensors/ is a different package.

Above src?

guibou · 2018-04-15T12:21:21Z

@dotlambda Thank you for the review, changes done.

dotlambda · 2018-04-15T12:27:05Z

@GrahamcOfBorg build python2.pkgs.pysensors python3.pkgs.pysensors

GrahamcOfBorg · 2018-04-15T12:28:08Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pysensors, python3.pkgs.pysensors

Partial log (click to expand)

writing manifest file 'sensors.egg-info/SOURCES.txt'
running build_ext
copying build/lib.linux-aarch64-3.6/sensors.cpython-36m-aarch64-linux-gnu.so ->

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/8vqc12pa0qwhizp15nqjs177c0wdvqq2-python2.7-pysensors-2018-04-15
/nix/store/kyfjiylbc9d5g0xxnz7bni5qamcqckd9-python3.6-pysensors-2018-04-15

dotlambda · 2018-04-15T12:34:50Z

Ran 0 tests in 0.000s

Can you try running the tests in https://github.com/bastienleonard/pysensors/tree/master/tests? Probably something like

checkPhase = ''
  ${python.interpreter} -m unittest discover
'';

guibou · 2018-04-15T13:08:56Z

@dotlambda

...
----------------------------------------------------------------------
Ran 3 tests in 0.000s

Done.

dotlambda · 2018-04-15T13:10:18Z

@GrahamcOfBorg build python2.pkgs.pysensors python3.pkgs.pysensors

GrahamcOfBorg · 2018-04-15T13:10:50Z

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.pysensors, python3.pkgs.pysensors

Partial log (click to expand)

    import sensors
ImportError: Kernel interface error


----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)
builder for '/nix/store/hqmq62pwy15w6bhbv1m8mqwlqavynn8a-python3.6-pysensors-2018-04-15.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/hqmq62pwy15w6bhbv1m8mqwlqavynn8a-python3.6-pysensors-2018-04-15.drv', '/nix/store/ysrjl96njqnbbw7d5wl0vqmzq6x18m6a-python2.7-pysensors-2018-04-15.drv' failed

dotlambda · 2018-04-15T13:13:59Z

ImportError: Kernel interface error

I guess that's a sandboxing thing. So we'll have to set doCheck = false after all (but you can keep the checkPhase). Please add a comment why tests are disabled.

guibou · 2018-04-15T13:18:27Z

@dotlambda

I wonder, perhaps aarch64-linux does not provide the sensors. I set doCheck = false, but it may be better to disable aarch64-linux in platforms?

dotlambda · 2018-04-15T13:22:46Z

lm_sensors isn't x86 only, so this one probably neither.
You can set platforms = platforms.linux however.

dotlambda · 2018-04-15T13:49:05Z

Btw, I'm getting the same error in a sandboxed x86 build, so this is really not ARM-specific.

dotlambda · 2018-04-15T13:50:50Z

pkgs/development/python-modules/pysensors/default.nix

@@ -0,0 +1,32 @@
+{ stdenv, buildPythonPackage, python, fetchFromGitHub, lm_sensors }:
+buildPythonPackage rec {
+  version = "2018-04-15";


I think this should rather be 2017-07-13.

dotlambda · 2018-05-10T17:40:42Z

@GrahamcOfBorg build python2.pkgs.pysensors python3.pkgs.pysensors

GrahamcOfBorg · 2018-05-10T17:41:25Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pysensors, python3.pkgs.pysensors

Partial log (click to expand)

/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/scvnjs2266ykq2iq1r7wc70zs0lidpxh-python3.6-pysensors-2017-07-13
shrinking /nix/store/scvnjs2266ykq2iq1r7wc70zs0lidpxh-python3.6-pysensors-2017-07-13/lib/python3.6/site-packages/sensors.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/scvnjs2266ykq2iq1r7wc70zs0lidpxh-python3.6-pysensors-2017-07-13/lib
patching script interpreter paths in /nix/store/scvnjs2266ykq2iq1r7wc70zs0lidpxh-python3.6-pysensors-2017-07-13
checking for references to /build in /nix/store/scvnjs2266ykq2iq1r7wc70zs0lidpxh-python3.6-pysensors-2017-07-13...
/nix/store/lmawfvhpwb77hbhrlga7m9nrsvdlja5y-python2.7-pysensors-2017-07-13
/nix/store/scvnjs2266ykq2iq1r7wc70zs0lidpxh-python3.6-pysensors-2017-07-13

GrahamcOfBorg · 2018-05-10T17:41:32Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pysensors, python3.pkgs.pysensors

Partial log (click to expand)

/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lw9ffsjjh1r4xdkhjbra8hb0gbsvwjsz-python3.6-pysensors-2017-07-13
shrinking /nix/store/lw9ffsjjh1r4xdkhjbra8hb0gbsvwjsz-python3.6-pysensors-2017-07-13/lib/python3.6/site-packages/sensors.cpython-36m-aarch64-linux-gnu.so
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lw9ffsjjh1r4xdkhjbra8hb0gbsvwjsz-python3.6-pysensors-2017-07-13/lib
patching script interpreter paths in /nix/store/lw9ffsjjh1r4xdkhjbra8hb0gbsvwjsz-python3.6-pysensors-2017-07-13
checking for references to /build in /nix/store/lw9ffsjjh1r4xdkhjbra8hb0gbsvwjsz-python3.6-pysensors-2017-07-13...
/nix/store/k2wvfd7b84jyh7wfa6420ajy2dxjf2km-python2.7-pysensors-2017-07-13
/nix/store/lw9ffsjjh1r4xdkhjbra8hb0gbsvwjsz-python3.6-pysensors-2017-07-13

guibou requested a review from FRidh as a code owner April 15, 2018 08:55

GrahamcOfBorg added the 6.topic: python label Apr 15, 2018

dotlambda requested changes Apr 15, 2018

View reviewed changes

guibou force-pushed the guibou_pysensors branch 2 times, most recently from e53c910 to 7166bb4 Compare April 15, 2018 12:20

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 15, 2018

guibou force-pushed the guibou_pysensors branch from 7166bb4 to 2461037 Compare April 15, 2018 13:08

guibou force-pushed the guibou_pysensors branch 2 times, most recently from 1ed212d to a984c80 Compare April 15, 2018 13:15

guibou force-pushed the guibou_pysensors branch from a984c80 to d20c2cf Compare April 15, 2018 13:48

dotlambda reviewed Apr 15, 2018

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Apr 15, 2018

guibou force-pushed the guibou_pysensors branch from d20c2cf to 6a2c781 Compare April 21, 2018 15:02

pysensors: init at 2017-07-13

6392fb3

guibou force-pushed the guibou_pysensors branch from 6a2c781 to 6392fb3 Compare April 21, 2018 15:03

dotlambda changed the title ~~pysensors: init at 2018-04-15~~ pysensors: init at 2017-07-13 May 10, 2018

dotlambda merged commit 71a561f into NixOS:master May 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pysensors: init at 2017-07-13 #38957

pysensors: init at 2017-07-13 #38957

guibou commented Apr 15, 2018

dotlambda Apr 15, 2018

dotlambda Apr 15, 2018

dotlambda Apr 15, 2018

dotlambda Apr 15, 2018

guibou Apr 15, 2018

dotlambda Apr 15, 2018

guibou commented Apr 15, 2018

dotlambda commented Apr 15, 2018

GrahamcOfBorg commented Apr 15, 2018

dotlambda commented Apr 15, 2018

guibou commented Apr 15, 2018

dotlambda commented Apr 15, 2018

GrahamcOfBorg commented Apr 15, 2018

dotlambda commented Apr 15, 2018

guibou commented Apr 15, 2018

dotlambda commented Apr 15, 2018

dotlambda commented Apr 15, 2018

dotlambda Apr 15, 2018

dotlambda commented May 10, 2018

GrahamcOfBorg commented May 10, 2018

GrahamcOfBorg commented May 10, 2018

pysensors: init at 2017-07-13 #38957

pysensors: init at 2017-07-13 #38957

Conversation

guibou commented Apr 15, 2018

Motivation for this change

Things done

dotlambda Apr 15, 2018

Choose a reason for hiding this comment

dotlambda Apr 15, 2018

Choose a reason for hiding this comment

dotlambda Apr 15, 2018

Choose a reason for hiding this comment

dotlambda Apr 15, 2018

Choose a reason for hiding this comment

guibou Apr 15, 2018

Choose a reason for hiding this comment

dotlambda Apr 15, 2018

Choose a reason for hiding this comment

guibou commented Apr 15, 2018

dotlambda commented Apr 15, 2018

GrahamcOfBorg commented Apr 15, 2018

dotlambda commented Apr 15, 2018

guibou commented Apr 15, 2018

dotlambda commented Apr 15, 2018

GrahamcOfBorg commented Apr 15, 2018

dotlambda commented Apr 15, 2018

guibou commented Apr 15, 2018

dotlambda commented Apr 15, 2018

dotlambda commented Apr 15, 2018

dotlambda Apr 15, 2018

Choose a reason for hiding this comment

dotlambda commented May 10, 2018

GrahamcOfBorg commented May 10, 2018

GrahamcOfBorg commented May 10, 2018