iputils: enable rarpd #38956
Merged
iputils: enable rarpd #38956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: iputils Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: iputils Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: iputils Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: iputils Partial log (click to expand)
|
Mic92
reviewed
Apr 15, 2018
| @@ -35,20 +35,21 @@ stdenv.mkDerivation rec { | |||
| installPhase = | |||
| '' | |||
| mkdir -p $out/bin | |||
| cp -p ping tracepath clockdiff arping rdisc $out/bin/ | |||
| cp -p ping tracepath clockdiff arping rdisc rarpd ninfod/ninfod $out/bin/ | |||
There was a problem hiding this comment.
The 3 lines below should be deleted in this case, because ninfod is added here.
There was a problem hiding this comment.
Fixed by removing the unconditional copy (this was a bit I got wrong while rebasing)
also add self to maintainers
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: iputils Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: iputils Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: iputils Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's useful for some obscure little use cases…
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)