Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde_frameworks: 5.44 -> 5.45 #38960

Merged
merged 2 commits into from Apr 19, 2018
Merged

kde_frameworks: 5.44 -> 5.45 #38960

merged 2 commits into from Apr 19, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Apr 15, 2018

Motivation for this change

It's still compiling, so I can't say for 100% that everything is working.

@adisbladis @ttuegel @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner April 15, 2018 10:22
@peterhoeg
Copy link
Member

How is it working so far?

@bkchr
Copy link
Contributor Author

bkchr commented Apr 17, 2018

I'm still on it. :)

@bkchr
Copy link
Contributor Author

bkchr commented Apr 17, 2018

I have some problems with msgfmt from gettext I think. It seems to be hanging somewhere, but I don't where exactly.

@bkchr
Copy link
Contributor Author

bkchr commented Apr 17, 2018

Okay, I found a bug report and a fix that could solve the problem I have: https://phabricator.kde.org/D12216
I will add the patch and test it tomorrow.

@bkchr
Copy link
Contributor Author

bkchr commented Apr 18, 2018

After adding the patch, compilation finally worked as expected :)

@peterhoeg peterhoeg merged commit b162c2c into NixOS:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @peterhoeg @GrahamcOfBorg