Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs: pip 9.0.3 -> 10.0.1 #38939

Merged
merged 11 commits into from May 9, 2018
Merged

python.pkgs: pip 9.0.3 -> 10.0.1 #38939

merged 11 commits into from May 9, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Apr 14, 2018 •
edited

Motivation for this change

Pip 10 has been released. I think the most interesting improvement for us is that the RECORD file in dist-info is now generated deterministically.

https://hydra.nixos.org/eval/1448410

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member Author

FRidh commented Apr 14, 2018 •
edited by dotlambda

This breaks docker-py which in effect breaks moto -> pandas (moto is test dependency) -> other stuff.

https://nix-cache.s3.amazonaws.com/log/kaw1dwx9x5qzp7xad2d8576ad8ksnxis-python2.7-docker-3.2.1.drv

@FRidh FRidh changed the title python.pkgs: pip 9.0.3 -> 10.0.0 python.pkgs: pip 9.0.3 -> 10.0.1 Apr 22, 2018
dotlambda
dotlambda approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to go.

@colemickens
Copy link
Member

Should this also update wheel too, that's used in pkgs/development/python-modules/bootstrapped-pip/default.nix, or is that a separate change?

@dotlambda
Copy link
Member

dotlambda commented May 2, 2018 •
edited

@colemickens Isn't that the one updated in 6d2dd33?

@FRidh
Copy link
Member Author

FRidh commented May 2, 2018

No, @colemickens refers to the 0.31.0 wheel release of April 1st. I intend to include that as well.

Waiting for my internet connection at home to get fixed though...

@dotlambda we can then also include the Python 2.7.15 release and possibly some other Python interpreter PR's from last week.

@dotlambda
Copy link
Member

@FRidh I just spotted

TODO: Shouldn't be necessary anymore for pip >= 10!

@FRidh
Copy link
Member Author

FRidh commented May 2, 2018

yea...I did not dare removing it just yet. It was added if I recall correctly to prevent certain occasional and hard-to-reproduce errors. We could remove it, as a separate commit, but within this PR.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python

Partial log (click to expand)

/nix/store/wwvx9cargzzmw6gp5l0y6hwiz0fyqma8-python-2.7.14

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python

Partial log (click to expand)

copying path '/nix/store/ls9w2cdlbz0y7nm8nn61ydii7b277d53-gcc-7.3.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/cjzdf7mkds5smbc99p7pq33107k50vxz-gdbm-1.14.1' from 'https://cache.nixos.org'...
copying path '/nix/store/60hcsid1cjcp7azbdl8ln8iqfmvn64m5-db-5.3.28-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/kgfc7gvagi1f067qm22wx74v7hpkwia8-ncurses-6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/c0z7mhzxydb0wzmb0n88pnfmfr98zqsd-openssl-1.0.2o' from 'https://cache.nixos.org'...
copying path '/nix/store/zwszb31gjajd38dkiarbn3s9gl97nf3j-readline-6.3p08' from 'https://cache.nixos.org'...
copying path '/nix/store/ww8vbrwr2mlqkzmxy5257ksg7zqr2kss-sqlite-3.22.0' from 'https://cache.nixos.org'...
copying path '/nix/store/amiamibmbwl969q4bd87qh496wp3s7wp-zlib-1.2.11' from 'https://cache.nixos.org'...
copying path '/nix/store/wwvx9cargzzmw6gp5l0y6hwiz0fyqma8-python-2.7.14' from 'https://cache.nixos.org'...
/nix/store/wwvx9cargzzmw6gp5l0y6hwiz0fyqma8-python-2.7.14

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python

Partial log (click to expand)

gzipping man pages under /nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14/share/man/
strip is /nix/store/gs3j0m07sw80657l5lkkrgzgi53nh5fi-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14/lib  /nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14/bin
patching script interpreter paths in /nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14
/nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14/lib/python2.7/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/ykdxb9bgcw9cryldfsz6yxjkyjayd9ka-bash-4.4-p19/bin/sh"
/nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14/lib/python2.7/config/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/ykdxb9bgcw9cryldfsz6yxjkyjayd9ka-bash-4.4-p19/bin/sh"
/nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14/lib/python2.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/ykdxb9bgcw9cryldfsz6yxjkyjayd9ka-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14...
wrong ELF type
/nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python

Partial log (click to expand)

these derivations will be built:
  /nix/store/zrzsrv3q66nc6hh97l2py3hmnq76v1aq-openssl-1.0.2o.drv
  /nix/store/r6krdsvrx5nlnzrpvvmnz5pqy6g9y8xi-python-2.7.14.drv
waiting for locks or build slots...
/nix/store/c38w7kbzjdmrc52cgnbw64m0hpf3nyfs-python-2.7.14

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python

Partial log (click to expand)

cannot build derivation '/nix/store/p6djkq96zj22iyz2b3pggbydgygl9m3w-ICU-osx-10.10.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/c67d31a2qpk66asl2l6d3jbrxmnsbgid-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/g1mpds3cx8248pv8xznzljnk38fd2g4b-CF-osx-10.10.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/rjmm60jf3d39yli662ax5j65sqnj28a2-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/21hvjwk2lasp49p7awsq9ypcpw1xvvry-python-2.7.14.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/p3m2gg2shbk78k4bw4inmnq14yhvhwr1-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/f5qxdm83mi8kb24b7jyzpnjwbl20rpas-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/rb6x38f99y6sk6l2z20116pya2dr5jln-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/s0v039a3lra1znddgn0xir1ki25bjs1j-python-2.7.14.drv': 15 dependencies couldn't be built
error: build of '/nix/store/s0v039a3lra1znddgn0xir1ki25bjs1j-python-2.7.14.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python

Partial log (click to expand)

cannot build derivation '/nix/store/p6djkq96zj22iyz2b3pggbydgygl9m3w-ICU-osx-10.10.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/c67d31a2qpk66asl2l6d3jbrxmnsbgid-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/g1mpds3cx8248pv8xznzljnk38fd2g4b-CF-osx-10.10.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/rjmm60jf3d39yli662ax5j65sqnj28a2-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/21hvjwk2lasp49p7awsq9ypcpw1xvvry-python-2.7.14.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/p3m2gg2shbk78k4bw4inmnq14yhvhwr1-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/f5qxdm83mi8kb24b7jyzpnjwbl20rpas-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/rb6x38f99y6sk6l2z20116pya2dr5jln-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/s0v039a3lra1znddgn0xir1ki25bjs1j-python-2.7.14.drv': 15 dependencies couldn't be built
error: build of '/nix/store/s0v039a3lra1znddgn0xir1ki25bjs1j-python-2.7.14.drv' failed

@FRidh FRidh merged commit 8ff2dca into staging May 9, 2018
@FRidh FRidh deleted the python-unstable branch May 9, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

Assignees
No one assigned
Labels
1.severity: mass-rebuild 2.status: work-in-progress 6.topic: python 6.topic: reproducible builds 8.has: documentation 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FRidh @colemickens @dotlambda @GrahamcOfBorg