Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node2nix: add nix as dependency (fix for #38946) #38947

Merged
merged 1 commit into from Apr 15, 2018

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Apr 14, 2018

Motivation for this change

#38946

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 14, 2018

cc @svanderburg

@svanderburg
Copy link
Member

I understand what this pull request is trying to solve. However, statically binding pkgs.nix as a runtime dependency also has a disadvantage -- it may be possible that the version pkgs.nix resolves to is not necessarily the same version as the Nix package manager that is being used, e.g. you may use an unstable version of Nix in your user profile.

This (in theory) could lead to compatibility issues, because the host system's nix-hash could work in a slightly different way.

I need to give this a bit of thought.

@srghma
Copy link
Contributor Author

srghma commented Apr 15, 2018

@svanderburg svanderburg merged commit fc7c95b into NixOS:master Apr 15, 2018
@svanderburg
Copy link
Member

I have merged it, but maybe in the future we need to think about a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants