Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sddm: add support for hidpi mode #40579

Merged
merged 1 commit into from May 30, 2018
Merged

sddm: add support for hidpi mode #40579

merged 1 commit into from May 30, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

This doesn't actually work yet as sddm 0.17 is slightly broken but it will from 0.18 so we might as well get ready for it and this doesn't break anything.

References:

  1. sddm login dialog is super small on my HiDPI laprop display after upgrading to 0.15 sddm/sddm#894
  2. Fix platform detection for EnableHiDPI sddm/sddm#992
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sddm

Partial log (click to expand)

  /nix/store/m35k1sqhwhv8qsc4klh6s9a6383c2jbn-qtsvg-5.10.1-bin
  /nix/store/qf0dffnsvri4k6asy65yd3h43d81q1sg-qtsvg-5.10.1
  /nix/store/rk0vw8cls6h8b6q34vfiihag3k96v464-sddm-0.17.0
copying path '/nix/store/3cs8nx00ny4hp09djbpp7mq42aqjqmhi-qtdeclarative-5.10.1' from 'https://cache.nixos.org'...
copying path '/nix/store/qf0dffnsvri4k6asy65yd3h43d81q1sg-qtsvg-5.10.1' from 'https://cache.nixos.org'...
copying path '/nix/store/bfjsc9n81ng11bkzqkffpm0h51222g5i-qtxmlpatterns-5.10.1' from 'https://cache.nixos.org'...
copying path '/nix/store/m35k1sqhwhv8qsc4klh6s9a6383c2jbn-qtsvg-5.10.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/fqq12lc3bq67d782bn6hxn471kg9jjff-qtdeclarative-5.10.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/rk0vw8cls6h8b6q34vfiihag3k96v464-sddm-0.17.0' from 'https://cache.nixos.org'...
/nix/store/rk0vw8cls6h8b6q34vfiihag3k96v464-sddm-0.17.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sddm

Partial log (click to expand)

shrinking /nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0/bin/sddm
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0/lib  /nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0/libexec  /nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0/bin
patching script interpreter paths in /nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0
/nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0/share/sddm/scripts/wayland-session: interpreter directive changed from "/bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
/nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0/share/sddm/scripts/Xsession: interpreter directive changed from " /bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/f1gz6l5mw6716gjgwfc8pi5nimir3lgq-sddm-0.17.0

@bkchr
Copy link
Contributor

bkchr commented May 16, 2018

LGTM.

@peterhoeg peterhoeg merged commit 159c157 into NixOS:master May 30, 2018
@peterhoeg peterhoeg deleted the m/sddm branch May 30, 2018 08:23
@peterhoeg peterhoeg restored the m/sddm branch May 30, 2018 17:27
@peterhoeg peterhoeg deleted the m/sddm branch October 8, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @GrahamcOfBorg @bkchr