New event for trimming recent changes and refactor lib/exe/indexer.php #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micgro42
changed the title
The matches our scheme of where_data_what better
|
Refactoring the TaskRunner can be the next step. For now this is already an improvement, so I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation behind this pull request is to trigger a new event when trimming the recent changes.
There are still a few things todo and a few things to maybe do:
lib/exe/indexer.phpinc/TaskRunner.phpa bit more?lib/exe/indexer.phptolib/exe/taskrunner.phpmore events?