Add missing tests for CSV.build with custom separator/quote_char #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Apr 25, 2018
asterite
approved these changes
Apr 25, 2018
sdogruyol
approved these changes
Apr 25, 2018
|
Thanks @Sija 👍 |
RX14
approved these changes
Apr 25, 2018
|
Now that's a weird CI failure: https://circleci.com/gh/crystal-lang/crystal/5688 I'm almost tempted to say the CPU's failing or something because I'm sure the VM host has ECC memory. |
|
Reran and it passed - I blame cosmic rays. |
chris-huxtable
pushed a commit
to chris-huxtable/crystal
that referenced
this pull request
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5998