Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pijul 0.8.0 -> 0.10.0 #40622

Closed
wants to merge 1 commit into from
Closed

Pijul 0.8.0 -> 0.10.0 #40622

wants to merge 1 commit into from

Conversation

sheganinans
Copy link
Contributor

Motivation for this change

This is a non-trivial verision bump.

Had to make quite a few changes:

  • sourceRoot was removed because target/release is now located the root directory not in ${name}/pijul
  • added pkgconfig, libsodium, and openssl

Requires additional testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji xeji mentioned this pull request May 17, 2018
Closed
8 tasks
@xeji
Copy link
Contributor

xeji commented May 17, 2018

#39317 does a similar update but uses carnix. I'm not sure which is the better approach.
cc @Mic92

@sellout
Copy link
Contributor

sellout commented Jun 16, 2018

This one seems the way to go from my perspective. If we later want to move from this version to carnix, that’s fine, but I don’t think there’s any reason to avoid getting the version bump done. I mean, this has already been here for a month, and I’d love to be using it.

@sheganinans
Copy link
Contributor Author

sheganinans commented Jun 17, 2018 via email

@xeji
Copy link
Contributor

xeji commented Jun 17, 2018

@GrahamcOfBorg build pijul

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pijul

Partial log (click to expand)

source root is pijul-0.10.0
unpacking source archive /nix/store/j36ha3n1ppvkfcksv3f978wanxvqnir3-pijul-0.10.0-vendor
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
building
Running cargo build --release
error: the lock file needs to be updated but --frozen was passed to prevent this
builder for '/nix/store/1lxv42jdwswriqc4ggf2kb6jkqipn02w-pijul-0.10.0.drv' failed with exit code 101
error: build of '/nix/store/1lxv42jdwswriqc4ggf2kb6jkqipn02w-pijul-0.10.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: pijul

Partial log (click to expand)

unpacking source archive /nix/store/3s6vdyzkly0mzhgbg2xq08n6mqrzgf2z-pijul-0.10.0.tar.gz
source root is pijul-0.10.0
unpacking source archive /nix/store/j36ha3n1ppvkfcksv3f978wanxvqnir3-pijul-0.10.0-vendor
patching sources
configuring
building
Running cargo build --release
error: the lock file needs to be updated but --frozen was passed to prevent this
builder for '/nix/store/a6p2s7vz0rdshbnhx8vh67h6g2x7s1rg-pijul-0.10.0.drv' failed with exit code 101
error: build of '/nix/store/a6p2s7vz0rdshbnhx8vh67h6g2x7s1rg-pijul-0.10.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: pijul

Partial log (click to expand)

unpacking source archive /nix/store/3s6vdyzkly0mzhgbg2xq08n6mqrzgf2z-pijul-0.10.0.tar.gz
source root is pijul-0.10.0
unpacking source archive /nix/store/j36ha3n1ppvkfcksv3f978wanxvqnir3-pijul-0.10.0-vendor
patching sources
configuring
building
Running cargo build --release
error: the lock file needs to be updated but --frozen was passed to prevent this
builder for '/nix/store/a7cc6x79av56zkh3x7mjxz5dq9b26c1h-pijul-0.10.0.drv' failed with exit code 101
error: build of '/nix/store/a7cc6x79av56zkh3x7mjxz5dq9b26c1h-pijul-0.10.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 17, 2018

Build fails, please fix.

@sellout
Copy link
Contributor

sellout commented Jun 17, 2018

This looks like the same failure @drostron ran into earlier.

@drostron
Copy link

Yes, I ran into the same failure when introducing this as an overlay. I had to override buildRustPackage's buildPhase removing the --frozen flag. That worked, but I'm not familiar enough with Rust builds to know the ramifications.

@tkerber
Copy link
Member

tkerber commented Jun 21, 2018

Without --frozen, rust will auto-update dependencies when necessary. It will fail in the sandbox.

@nanexcool
Copy link

Any updates on this? Mine is failing with:

source root is pijul-0.10.0
unpacking source archive /nix/store/j36ha3n1ppvkfcksv3f978wanxvqnir3-pijul-0.10.0-vendor
patching sources
configuring
building
Running cargo build --release 
error: the lock file needs to be updated but --frozen was passed to prevent this

@sheganinans
Copy link
Contributor Author

Seems upstream Rust needs to update its dependencies before this will build. Upstream Rust has been taking too long to do so, I suggest we merge #39317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sheganinans @xeji @sellout @GrahamcOfBorg @drostron @tkerber @nanexcool