Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dyncall: install cmake modules, man pages, use upstream's preferred URL #40615

Merged
merged 1 commit into from May 16, 2018
Merged

dyncall: install cmake modules, man pages, use upstream's preferred URL #40615

merged 1 commit into from May 16, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 16, 2018

Various minor improvements for folks wanting to dev against dyncall.

Disabling tests in favor of crashing and pretending things work ;).
Spent too much time trying to fix the test suite,
but it has multiple problems that convince me
that it's not intended for our use. Yet!

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dyncall

Partial log (click to expand)

cp /build/dyncall-1.0/./dynload/dynload.h  /nix/store/876j6af8jm8bms8vjz8rf71rh6x2x2y0-dyncall-1.0/include
make[1]: Leaving directory '/build/dyncall-1.0/dynload'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/876j6af8jm8bms8vjz8rf71rh6x2x2y0-dyncall-1.0
gzipping man pages under /nix/store/876j6af8jm8bms8vjz8rf71rh6x2x2y0-dyncall-1.0/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/876j6af8jm8bms8vjz8rf71rh6x2x2y0-dyncall-1.0/lib
patching script interpreter paths in /nix/store/876j6af8jm8bms8vjz8rf71rh6x2x2y0-dyncall-1.0
checking for references to /build in /nix/store/876j6af8jm8bms8vjz8rf71rh6x2x2y0-dyncall-1.0...
/nix/store/876j6af8jm8bms8vjz8rf71rh6x2x2y0-dyncall-1.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: dyncall

Partial log (click to expand)

mkdir -p /nix/store/irkflayn040217cb3a8z7c5hsj518v6m-dyncall-1.0/include
cp libdynload_s.a /nix/store/irkflayn040217cb3a8z7c5hsj518v6m-dyncall-1.0/lib
cp /private/tmp/nix-build-dyncall-1.0.drv-0/dyncall-1.0/./dynload/dynload.h  /nix/store/irkflayn040217cb3a8z7c5hsj518v6m-dyncall-1.0/include
make[1]: Leaving directory '/private/tmp/nix-build-dyncall-1.0.drv-0/dyncall-1.0/dynload'
post-installation fixup
gzipping man pages under /nix/store/irkflayn040217cb3a8z7c5hsj518v6m-dyncall-1.0/share/man/
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/irkflayn040217cb3a8z7c5hsj518v6m-dyncall-1.0/lib
patching script interpreter paths in /nix/store/irkflayn040217cb3a8z7c5hsj518v6m-dyncall-1.0
/nix/store/irkflayn040217cb3a8z7c5hsj518v6m-dyncall-1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dyncall

Partial log (click to expand)

cp /build/dyncall-1.0/./dynload/dynload.h  /nix/store/w8fpavm1c37fa28bqpl7wwgm0jra9ha2-dyncall-1.0/include
make[1]: Leaving directory '/build/dyncall-1.0/dynload'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w8fpavm1c37fa28bqpl7wwgm0jra9ha2-dyncall-1.0
gzipping man pages under /nix/store/w8fpavm1c37fa28bqpl7wwgm0jra9ha2-dyncall-1.0/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w8fpavm1c37fa28bqpl7wwgm0jra9ha2-dyncall-1.0/lib
patching script interpreter paths in /nix/store/w8fpavm1c37fa28bqpl7wwgm0jra9ha2-dyncall-1.0
checking for references to /build in /nix/store/w8fpavm1c37fa28bqpl7wwgm0jra9ha2-dyncall-1.0...
/nix/store/w8fpavm1c37fa28bqpl7wwgm0jra9ha2-dyncall-1.0

@dtzWill dtzWill merged commit 1291111 into NixOS:master May 16, 2018
@dtzWill dtzWill deleted the fix/dyncall-touchup branch May 16, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg