Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ee951c348b3b
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ec1ee660c995
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on May 16, 2018

  1. nixos/tests/mesos: wait for all services and ports 

    to be available before sending requests.
Avoids non-deterministic test failure.

(cherry picked from commit 0d2a4ed)
    @xeji
    xeji committed May 16, 2018
    Copy the full SHA
    345f14e View commit details

  2. nixos/mesos-slave: start after docker 

    If docker is enabled, start mesos-slave.service after docker.service
to avoid a race condition that could result in mesos-slave to fail
with "Failed to create docker: Timed out getting docker version"

(cherry picked from commit ec00b6f)
    @xeji
    xeji committed May 16, 2018
    Copy the full SHA
    ec1ee66 View commit details
Showing with 4 additions and 2 deletions.
  1. +1 −1 nixos/modules/services/misc/mesos-slave.nix
  2. +3 −1 nixos/tests/mesos.nix
2 changes: 1 addition & 1 deletion nixos/modules/services/misc/mesos-slave.nix
View file
Original file line number Diff line number Diff line change
@@ -187,7 +187,7 @@ in {
systemd.services.mesos-slave = {
description = "Mesos Slave";
wantedBy = [ "multi-user.target" ];
after = [ "network.target" ];
after = [ "network.target" ] ++ optionals cfg.withDocker [ "docker.service" ] ;
path = [ pkgs.stdenv.shellPackage ];
serviceConfig = {
ExecStart = ''
4 changes: 3 additions & 1 deletion nixos/tests/mesos.nix
View file
Original file line number Diff line number Diff line change
@@ -66,9 +66,11 @@ import ./make-test.nix ({ pkgs, ...} : rec {
testScript =
''
startAll;
$master->waitForUnit("zookeeper.service");
$master->waitForUnit("mesos-master.service");
$slave->waitForUnit("docker.service");
$slave->waitForUnit("mesos-slave.service");
$master->waitForOpenPort(2181);
$master->waitForOpenPort(5050);
$slave->waitForOpenPort(5051);