Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iasl: 20180313 -> 20180508 #40613

Merged
merged 1 commit into from May 18, 2018
Merged

iasl: 20180313 -> 20180508 #40613

merged 1 commit into from May 18, 2018

Conversation

Synthetica9
Copy link
Member

Motivation for this change

Cherry-picked from #40608

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: iasl

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7npniq2lclj2j9dll49i5d9iv2a7m1a3-iasl-20180508
shrinking /nix/store/7npniq2lclj2j9dll49i5d9iv2a7m1a3-iasl-20180508/bin/iasl
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7npniq2lclj2j9dll49i5d9iv2a7m1a3-iasl-20180508/bin
patching script interpreter paths in /nix/store/7npniq2lclj2j9dll49i5d9iv2a7m1a3-iasl-20180508
checking for references to /build in /nix/store/7npniq2lclj2j9dll49i5d9iv2a7m1a3-iasl-20180508...
/nix/store/7npniq2lclj2j9dll49i5d9iv2a7m1a3-iasl-20180508

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: iasl

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wmmdfa9jgbdjg1g4nxsrpa4ilbkf5x48-iasl-20180508
shrinking /nix/store/wmmdfa9jgbdjg1g4nxsrpa4ilbkf5x48-iasl-20180508/bin/iasl
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wmmdfa9jgbdjg1g4nxsrpa4ilbkf5x48-iasl-20180508/bin
patching script interpreter paths in /nix/store/wmmdfa9jgbdjg1g4nxsrpa4ilbkf5x48-iasl-20180508
checking for references to /build in /nix/store/wmmdfa9jgbdjg1g4nxsrpa4ilbkf5x48-iasl-20180508...
/nix/store/wmmdfa9jgbdjg1g4nxsrpa4ilbkf5x48-iasl-20180508

@xeji xeji merged commit 5e49920 into NixOS:master May 18, 2018
xeji added a commit that referenced this pull request May 19, 2018
@xeji
Revert "iasl: 2018031 -> 20180508 (#40613)"
bd6a3b2 
Broke xen and virtualbox.
This reverts commit 5e49920.
@xeji
Copy link
Contributor

xeji commented May 19, 2018

This breaks xen and virtualbox: https://hydra.nixos.org/eval/1457705#tabs-now-fail

Reverted in bd6a3b2

@Synthetica9
Copy link
Member Author

Oh, yikes... Should we file an issue upstream?

@xeji
Copy link
Contributor

xeji commented May 19, 2018

Yes, after some investigation to rule out nixpkgs-specific issues.
FWIW, Gentoo currently uses iasl 20171215, Arch and Ubuntu have 20180105.
Maybe we should stick to our current version for now. What's the benefit of being bleeding edge here?

Synthetica9 pushed a commit to Synthetica9/nixpkgs that referenced this pull request May 19, 2018
@xeji @Synthetica9
Revert "iasl: 2018031 -> 20180508 (NixOS#40613)"
92ef2ef 
Broke xen and virtualbox.
This reverts commit 5e49920.
@Synthetica9 Synthetica9 mentioned this pull request May 19, 2018
Closed
8 tasks
@xeji xeji mentioned this pull request May 21, 2018
Closed
@xeji xeji mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @GrahamcOfBorg @xeji